Merge lp://staging/~mbp/launchpad/800295-delete-buildd into lp://staging/launchpad

Proposed by Martin Pool
Status: Merged
Approved by: Martin Pool
Approved revision: no longer in the source branch.
Merged at revision: 14311
Proposed branch: lp://staging/~mbp/launchpad/800295-delete-buildd
Merge into: lp://staging/launchpad
Diff against target: 9037 lines (+19/-8598)
63 files modified
.bzrignore (+0/-8)
buildout.cfg (+4/-2)
lib/canonical/buildd/Makefile (+0/-19)
lib/canonical/buildd/README (+0/-47)
lib/canonical/buildd/__init__.py (+0/-5)
lib/canonical/buildd/binarypackage.py (+0/-133)
lib/canonical/buildd/buildd-config.py (+0/-54)
lib/canonical/buildd/buildd-slave-example.conf (+0/-25)
lib/canonical/buildd/buildd-slave.tac (+0/-55)
lib/canonical/buildd/buildrecipe (+0/-220)
lib/canonical/buildd/check-implicit-pointer-functions (+0/-118)
lib/canonical/buildd/debian.py (+0/-239)
lib/canonical/buildd/debian/changelog (+0/-698)
lib/canonical/buildd/debian/compat (+0/-1)
lib/canonical/buildd/debian/control (+0/-17)
lib/canonical/buildd/debian/launchpad-buildd.cron.daily (+0/-10)
lib/canonical/buildd/debian/launchpad-buildd.examples (+0/-1)
lib/canonical/buildd/debian/launchpad-buildd.init (+0/-98)
lib/canonical/buildd/debian/postinst (+0/-101)
lib/canonical/buildd/debian/rules (+0/-96)
lib/canonical/buildd/debian/source/format (+0/-1)
lib/canonical/buildd/debian/upgrade-config (+0/-122)
lib/canonical/buildd/generate-translation-templates (+0/-66)
lib/canonical/buildd/mount-chroot (+0/-25)
lib/canonical/buildd/override-sources-list (+0/-31)
lib/canonical/buildd/pottery/generate_translation_templates.py (+0/-114)
lib/canonical/buildd/pottery/intltool.py (+0/-342)
lib/canonical/buildd/remove-build (+0/-25)
lib/canonical/buildd/sbuild (+0/-3658)
lib/canonical/buildd/sbuild-package (+0/-92)
lib/canonical/buildd/sbuild.conf (+0/-155)
lib/canonical/buildd/sbuildrc (+0/-32)
lib/canonical/buildd/scan-for-processes (+0/-43)
lib/canonical/buildd/slave.py (+0/-686)
lib/canonical/buildd/sourcepackagerecipe.py (+0/-144)
lib/canonical/buildd/template-buildd-slave.conf (+0/-32)
lib/canonical/buildd/test_buildd_generatetranslationtemplates (+0/-33)
lib/canonical/buildd/test_buildd_recipe (+0/-48)
lib/canonical/buildd/tests/__init__.py (+0/-4)
lib/canonical/buildd/tests/buildd-slave-test.conf (+0/-27)
lib/canonical/buildd/tests/buildlog (+0/-23)
lib/canonical/buildd/tests/buildlog.long (+0/-82)
lib/canonical/buildd/tests/harness.py (+0/-139)
lib/canonical/buildd/tests/test_1.diff (+0/-17)
lib/canonical/buildd/tests/test_2.diff (+0/-32)
lib/canonical/buildd/tests/test_buildd_slave.py (+0/-198)
lib/canonical/buildd/tests/test_check_implicit_pointer_functions.py (+0/-43)
lib/canonical/buildd/tests/test_harness.py (+0/-10)
lib/canonical/buildd/tests/test_translationtemplatesbuildmanager.py (+0/-173)
lib/canonical/buildd/translationtemplates.py (+0/-99)
lib/canonical/buildd/umount-chroot (+0/-40)
lib/canonical/buildd/unpack-chroot (+0/-52)
lib/canonical/buildd/update-debian-chroot (+0/-45)
lib/canonical/launchpad/daemons/readyservice.py (+0/-6)
lib/lp/buildmaster/model/builder.py (+3/-3)
lib/lp/buildmaster/tests/mock_slaves.py (+1/-1)
lib/lp/buildmaster/tests/test_builder.py (+2/-1)
lib/lp/buildmaster/tests/test_manager.py (+2/-1)
lib/lp/testing/factory.py (+0/-1)
lib/lp/translations/tests/test_generate_translation_templates.py (+5/-2)
lib/lp/translations/tests/test_pottery_detect_intltool.py (+1/-1)
scripts/rosetta/pottery-generate-intltool.py (+1/-1)
utilities/snakefood/lp-sfood-packages (+0/-1)
To merge this branch: bzr merge lp://staging/~mbp/launchpad/800295-delete-buildd
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+81815@code.staging.launchpad.net

Commit message

[r=mbp][bug=800295] delete lib/canonical/buildd and use lp:launchpad-buildd instead

Description of the change

Further to bug 800295, this

 * deletes the lib/canonical/buildd directory
 * changes tests that need the buildd packages to load them from the 'lpbuildd' package instead
 * inserts onto the pythonpath the /usr/share/launchpad-buildd directory into which the launchpad-buildd deb package installs the lpbuildd python package

This cannot be landed until the lpbuildd package is added as a deb dependency of Launchpad, which requires some more work to separate 'acts as a buildd' from 'provides the lpbuildd python package', and preferably also a deployment of the new launchpad-buildd package to prove it works ok.

Eventually we might want to remove the test-time dependencies altogether in favour of testing against a fake <https://dev.launchpad.net/ArchitectureGuide/ServicesRequirements#Test_fake> and having separate integration qa. But I think this is a safer step forward to make the split while keeping the same tests in place.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

after discussion with elmo and others, i'm going to split the binaries to a separate package and make it disabled by default

Revision history for this message
Martin Pool (mbp) wrote :

lp:launchpad-buildd now splits out a separate python-lpbuildd package, and the main launchpad-buildd package will not run unless it is specifically enabled. now i'm going to proceed with adding it as a developer dependency.

Revision history for this message
Martin Pool (mbp) wrote :

it turned out that it is not easily possible for lamont to change the setting, so in http://bazaar.launchpad.net/~launchpad-dev/launchpad-buildd/trunk/revision/17 i've made it just autostart based on the hostname, which should be tolerably safe for other people without disrupting the buildds

i've added python-lpbuildd to launchpad-developer-dependencies in https://code.launchpad.net/~launchpad-committers/meta-lp-deps/trunk

i apparently need to manually update the ec2 image before it can be relied upon

i've created a recipe building from lp:launchpad-buildd into the launchpad ppa

Revision history for this message
Martin Pool (mbp) wrote :

i ran this through ec2 with https://code.launchpad.net/~mbp/launchpad/ec2-update/+merge/81946 to let it be tested, and it did not find the right buildd package. i'm not sure why; probably i've done something wrong in buildout.

Revision history for this message
Martin Pool (mbp) wrote :

With an updated ec2test image and with ec2test set to update packages before running, this did work.

based on the general approach having been thoroughly discussed and the actual patch being big and mechanical, i'm going to treat this as approved.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

W00t!

Revision history for this message
Martin Pool (mbp) wrote :

this was reverted because it failed on buildbot

 https://code.launchpad.net/~mbp/launchpad/800295-protocol/+merge/82629 removes one more bit of coupling

python-lpbuildd is installed on buildbot

i'm going to re-send this.

Revision history for this message
Martin Pool (mbp) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.