Launchpad itself

Merge lp://staging/~mbp/launchpad/721166-test-gc-warnings into lp://staging/launchpad

721166-test-gc-warnings
Merge into devel

Proposed by Martin Pool on 2011-07-27

Status:

Merged

Approved by:

Martin Pool on 2011-07-27

Approved revision:

no longer in the source branch.

Merged at revision:

13916

Proposed branch:

lp://staging/~mbp/launchpad/721166-test-gc-warnings

Merge into:

lp://staging/launchpad

Prerequisite:

lp://staging/~jelmer/launchpad/bzr-2.4b4

Diff against target:

1 lines (+0/-0)

0 files modified

To merge this branch:

bzr merge lp://staging/~mbp/launchpad/721166-test-gc-warnings

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Henning Eggers		2011-07-27	Pending
Review via email: mp+69381@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-07-25.

Commit message

[r=mbp][bug=721166] reenable test_sphinxdocs now bzr 2.4 is landed

Description of the change

Per discussion in bug 721166: now that bzr doesn't emit gc warning cruft, some Launchpad tests can be reenabled.

(I don't know if they're especially important tests, but it is a critical bug, so nice to close it off.)

Revision history for this message

Henning Eggers (henninge) wrote on 2011-07-25: Posted in a previous version of this proposal

Thanks for doing this. I can confirm that the test now passes even after repeating it 20 times.

review: Approve

Revision history for this message

Martin Pool (mbp) wrote on 2011-07-27: Posted in a previous version of this proposal

This passed locally for me and for Henning, but failed in ec2, I guess because our local copies are actually loading bzr 2.4, but official Launchpad does not have that yet, and that's where the fix for bug 791612 was landed. So this should be possible to fix once https://code.launchpad.net/~jelmer/launchpad/bzr-2.4b4/+merge/68830 is merged.