Merge lp://staging/~mbp/launchpad/714381-beta-font into lp://staging/launchpad
Proposed by
Martin Pool
Status: | Merged |
---|---|
Approved by: | Martin Pool |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14471 |
Proposed branch: | lp://staging/~mbp/launchpad/714381-beta-font |
Merge into: | lp://staging/launchpad |
Diff against target: |
249 lines (+20/-20) 18 files modified
lib/canonical/launchpad/icing/css/base.css (+1/-1) lib/canonical/launchpad/icing/css/forms.css (+1/-1) lib/canonical/launchpad/icing/css/modifiers.css (+1/-1) lib/canonical/launchpad/icing/css/typography.css (+1/-1) lib/canonical/launchpad/icing/shipit.css (+2/-2) lib/canonical/launchpad/icing/style.css (+2/-2) lib/canonical/launchpad/icing/yui_2.7.0b/build/calendar/assets/skins/sam/calendar-skin.css (+1/-1) lib/canonical/launchpad/offline-maintenance-haproxy.html (+1/-1) lib/canonical/launchpad/offline-maintenance.html (+1/-1) lib/canonical/launchpad/offline-staging-code-update.html (+1/-1) lib/canonical/launchpad/offline-staging-db-update.html (+1/-1) lib/canonical/launchpad/offline-unplanned-haproxy.html (+1/-1) lib/canonical/launchpad/offline-unplanned.html (+1/-1) lib/canonical/launchpad/webapp/error.py (+1/-1) lib/canonical/launchpad/webapp/templates/oops-veryplain.pt (+1/-1) lib/lp/app/templates/launchpad-databaseunavailable.pt (+1/-1) lib/lp/code/templates/sourcepackagerecipe-index.pt (+1/-1) utilities/apidoc-index.pt (+1/-1) |
To merge this branch: | bzr merge lp://staging/~mbp/launchpad/714381-beta-font |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+84716@code.staging.launchpad.net |
Commit message
[r=jtv][bug=714381] remove UbuntuBeta font from css
Description of the change
This removes references to the UbuntuBeta font per bug 714381: fairly trivial
but fairly easy to fix:
* some of the names were wrong and pointed to fonts that never existed
* the beta is now over
* the existing code prefers the beta fonts to the release fonts, if someone
does have the beta still installed, which seems bad
* old clients ought to get the Ubuntu release fonts from web fonts anyhow
To post a comment you must log in.
I don't think 714831 was the right bug number!
Generally looks good. It seems ugly to quote some font names but not others; then again this is CSS, not code.
In lib/lp/ code/templates/ sourcepackagere cipe-index. pt maybe it would be a nice touch to separate the font names by adding a space after the comma. But that's a pre-existing thing.