Bazaar

Merge lp://staging/~mbp/bzr/715000-more-fallbacks into lp://staging/bzr

715000-more-fallbacks
Merge into bzr.dev

Proposed by Martin Pool on 2011-02-09

Status:	Superseded
Proposed branch:	lp://staging/~mbp/bzr/715000-more-fallbacks
Merge into:	lp://staging/bzr
Prerequisite:	lp://staging/bzr/2.2
Diff against target:	417 lines (+98/-111) 8 files modified bzr (+0/-4) bzrlib/__init__.py (+0/-4) bzrlib/groupcompress.py (+5/-5) bzrlib/knit.py (+13/-13) bzrlib/tests/per_repository_reference/test_graph.py (+1/-1) bzrlib/versionedfile.py (+6/-5) doc/en/release-notes/bzr-2.2.txt (+73/-3) doc/en/release-notes/bzr-2.3.txt (+0/-76)
To merge this branch:	bzr merge lp://staging/~mbp/bzr/715000-more-fallbacks
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
bzr-core		2011-02-09	Pending
Review via email: mp+49027@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-02-09.

This proposal has been superseded by a proposal from 2011-02-09.

Description of the change

follow-through from bug 715000: rename _fallback_vfs to _immediate_fallbacks to make it clear it's not the whole stack.

Revision history for this message

John A Meinel (jameinel) wrote on 2011-02-09: Posted in a previous version of this proposal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/9/2011 2:08 AM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/715000-more-fallbacks into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr/715000-more-fallbacks/+merge/49025
>
> follow-through from bug 715000: rename _fallback_vfs to _immediate_fallbacks to make it clear it's not the whole stack.

I'm ok with the change, but I would make it "_immediate_fallback_vfs" to
distinguish it from "_immediate_fallback_repositories".
Mostly to be easily greppable.

I don't personally find it better, mostly because the added length
doesn't add much. It seems a simple

:ivar _fallback_vfs: Immediate fallbacks, note this is not transitive

Could be a better way to go.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1St0oACgkQJdeBCYSNAAOLHQCg0Yj/BsMKAzL4Sr5OhGQbxBoZ
9FMAnj/yOfdMjxhNnjLFiYvdnY9+ansx
=LcsQ
-----END PGP SIGNATURE-----

Revision history for this message

John A Meinel (jameinel) wrote on 2011-02-09: Posted in a previous version of this proposal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/9/2011 2:09 AM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/715000-more-fallbacks into lp:bzr/2.2.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr/715000-more-fallbacks/+merge/49026
>
> follow-through from bug 715000: rename _fallback_vfs to _immediate_fallbacks to make it clear it's not the whole stack.

I don't really like changing the name of things in a stable series. Do
you feel this is really necessary?

review: needs_information

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1St2gACgkQJdeBCYSNAAPIYwCeJ4s9T48rbxRduTts3rarhkPu
1UMAoKDzNFENu713ShbJuPiCF9zDJQdi
=F4wU
-----END PGP SIGNATURE-----