Merge lp://staging/~mbp/bzr-gtk/707482-typeerror into lp://staging/bzr-gtk/gtk2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/26/2011 9:01 PM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr-gtk/707482-typeerror into lp:bzr-gtk.
>
> Requested reviews:
> Bazaar GTK maintainers (bzr-gtk)
> Related bugs:
> #707482 gannotate wrong column type
> https://bugs.launchpad.net/bugs/707482
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr-gtk/707482-typeerror/+merge/47628
>
> Per <https://bugs.launchpad.net/bzr-gtk/+bug/707482>, we shouldn't assume that you can just poke ints into a string-typed list model column.
>
> (My editor also changed some tabs to spaces, consistent with the rest of the file.)

I followed the conversation, and your logic is sensible here. I'm not
super familiar with pygtk, but your changes seem good to me.

I certainly agree that doing string compares to jump to a line number is
a bit odd, but hey, no worse than it was.

So approve from me, at least.
 review: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1BG64ACgkQJdeBCYSNAAN0YwCgqzZxMApidpF6vhSShllo6Tv2
hVcAn1SFDnmc1YT6vFTrn2ya4WnrXuOJ
=59pA
-----END PGP SIGNATURE-----

Hi Martin.

Thank you for the branch. This does fix the gtk column type issue in gannotate.