Merge lp://staging/~maxiberta/ols-jenkaas/packagereview-job-add-build-setup-command into lp://staging/ols-jenkaas

Proposed by Maximiliano Bertacchini
Status: Work in progress
Proposed branch: lp://staging/~maxiberta/ols-jenkaas/packagereview-job-add-build-setup-command
Merge into: lp://staging/ols-jenkaas
Diff against target: 57 lines (+7/-11)
2 files modified
jobs/packagereview.yaml (+2/-0)
jobs/project-charm.yaml (+5/-11)
To merge this branch: bzr merge lp://staging/~maxiberta/ols-jenkaas/packagereview-job-add-build-setup-command
Reviewer Review Type Date Requested Status
Online Services Jenkaas Administrators Pending
Review via email: mp+427115@code.staging.launchpad.net

Commit message

Update deps prior to building the packagereview charm

Description of the change

The landing job has a "setup" setup prior to running, where most projects run `make update-dependencies`. The charm build job, otoh, has no explicit setup step (it's /bin/true, actually).

Should fix "ERROR: Could not find a version that satisfies the requirement snapstore-schemas==1.75 (from -r requirements.txt (line 96)) (from versions: 0.98, 1.13, 1.18, 1.19, 1.20, 1.23, 1.27, 1.28, 1.30, 1.31, 1.33, 1.34, 1.41, 1.61, 1.62, 1.63, 1.64, 1.65, 1.66, 1.67, 1.68, 1.69, 1.70, 1.71, 1.72, 1.73, 1.74)" (e.g. https://jenkins.ols.canonical.com/online-services/job/packagereview-build-charm/355/console). Most probably caused by the landing job and charm build job running in a different workers, and deps updated in the former only.

Alternatively, and more aggressively, could update the {name}-build-charm template to run '{setup}' instead of /bin/true.

Check commit messages for details.

To post a comment you must log in.

Unmerged revisions

837. By Maximiliano Bertacchini

Add a build-setup-command to the packagereview charm build job

836. By Maximiliano Bertacchini

Extend the {name}-build-charm job template to support a custom setup command

As a result, job templates {name}-build-charm and {name}-build-asset are identical.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches