loggerhead

Merge lp://staging/~maxb/loggerhead/jameinel-configurable_logging into lp://staging/loggerhead

jameinel-configurable_logging
Merge into trunk-rich

Proposed by Max Bowsher on 2011-03-10

Status:	Merged
Approved by:	Jelmer Vernooij on 2011-03-16
Approved revision:	417
Merged at revision:	435
Proposed branch:	lp://staging/~maxb/loggerhead/jameinel-configurable_logging
Merge into:	lp://staging/loggerhead
Diff against target:	164 lines (+60/-8) 6 files modified __init__.py (+13/-0) loggerhead/config.py (+33/-0) loggerhead/controllers/__init__.py (+2/-2) loggerhead/main.py (+11/-1) loggerhead/wholehistory.py (+1/-1) loggerhead/zptsupport.py (+0/-4)
To merge this branch:	bzr merge lp://staging/~maxb/loggerhead/jameinel-configurable_logging
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jelmer Vernooij	code	2011-03-10	Needs Fixing on 2011-03-16
Review via email: mp+52854@code.staging.launchpad.net

Commit message

Allow the log level to be set at startup/in config, rather than always debug.

Also, expose log level for 'bzr serve --http'

Description of the change

This is a simple re-push and re-propose of lp:~jameinel/loggerhead/configurable_logging, to track that this piece of work de-merged in the switching around of trunk exists as an independently re-landable entity.

Revision history for this message

John A Meinel (jameinel) wrote on 2011-03-10:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/10/2011 03:17 PM, Max Bowsher wrote:
> Max Bowsher has proposed merging lp:~maxb/loggerhead/jameinel-configurable_logging into lp:loggerhead.
>
> Requested reviews:
> Loggerhead-team (loggerhead-team)
>
> For more details, see:
> https://code.launchpad.net/~maxb/loggerhead/jameinel-configurable_logging/+merge/52854
>
> This is a simple re-push and re-propose of lp:~jameinel/loggerhead/configurable_logging, to track that this piece of work de-merged in the switching around of trunk exists as an independently re-landable entity.

I would also like to see this land, since it makes it both quites the
simpleTALES spam, and makes it easier to set a default log level. Mostly
for interactive testing.

I think this one could be considered 'approved', though we can wait a
day or two to see if someone has something to say.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk143rwACgkQJdeBCYSNAANNFQCgjDlU8HlMNwriB9yVAMJt4Vi2
OsMAoLLUxXhcMEKMMMCtGf+RBiiSQKpP
=3DA1
-----END PGP SIGNATURE-----

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2011-03-16:

There seems to be a fair bit of duplication between bzrlib.plugins.loggerhead.setup_logging and loggerhead.main.setup_loggin. It'd be great if that could be refactored into a common function.

review: Needs Fixing (code)