Merge lp://staging/~maxb/editmoin/message-display-fix into lp://staging/editmoin
Proposed by
Max Bowsher
| Status: | Merged |
|---|---|
| Merge reported by: | Gustavo Niemeyer |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~maxb/editmoin/message-display-fix |
| Merge into: | lp://staging/editmoin |
| Diff against target: |
25 lines (+5/-3) 1 file modified
editmoin (+5/-3) |
| To merge this branch: | bzr merge lp://staging/~maxb/editmoin/message-display-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Niemeyer | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Max Bowsher (maxb) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I find that editmoin displays the message that Moin provides on starting an edit session (which tells you how long you hold the edit lock) twice, working on my office's wiki. Looking at the code I see that editmoin displays this message zero or more times, once every time a regex match for an optional data item fails.
Here is a small change to display the message once, always, rather than the above strange behaviour.