Merge lp://staging/~matzipan/scratch/use-rename-event into lp://staging/~elementary-apps/scratch/scratch
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~matzipan/scratch/use-rename-event |
| Merge into: | lp://staging/~elementary-apps/scratch/scratch |
| Diff against target: |
1847 lines (+463/-1120) 16 files modified
plugins/CMakeLists.txt (+1/-2) plugins/filemanager/CMakeLists.txt (+0/-29) plugins/filemanager/File.vala (+0/-207) plugins/filemanager/FileManagerPlugin.vala (+0/-113) plugins/filemanager/FileView.vala (+0/-297) plugins/filemanager/Settings.vala (+0/-36) plugins/filemanager/filemanager.plugin (+0/-10) plugins/folder-manager/CMakeLists.txt (+2/-0) plugins/folder-manager/File.vala (+79/-101) plugins/folder-manager/FileItem.vala (+39/-0) plugins/folder-manager/FileView.vala (+92/-254) plugins/folder-manager/FolderItem.vala (+196/-0) plugins/folder-manager/FolderManagerPlugin.vala (+50/-56) plugins/folder-manager/folder-manager.plugin (+4/-4) schemas/CMakeLists.txt (+0/-1) schemas/org.pantheon.scratch.plugins.file-manager.gschema.xml (+0/-10) |
| To merge this branch: | bzr merge lp://staging/~matzipan/scratch/use-rename-event |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch is WIP.
Currently, if you rename a file in the sidebar, when you perform the action, the selected file cursor jumps to a different file. This is because the sidebar doesn't use the rename GIO event, but instead deletes and creates the row everytime this happens.
However, using the rename event doesn't fully work, because Granite.SourceList doesn't have a way to trigger re-sorting of the elements. It only sorts an element when it is first added.
Thus, I am pushing this now as it is, in the hopes that I will address this issue in my sidebar-widget branch in granite. Then it can be merged into scratch.
Unmerged revisions
- 1780. By Zisu Andrei
-
Use rename monitor event instead of create/remove
- 1779. By Zisu Andrei
-
Simplify file/folder validity check. Move common construct/
rename/ trash code into superclass. GObject constructor for File - 1778. By Zisu Andrei
-
Merge filemanager into folder-manager
