Merge lp://staging/~matzipan/scratch/folder-manager-improvement into lp://staging/~elementary-apps/scratch/scratch
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~matzipan/scratch/folder-manager-improvement |
Merge into: | lp://staging/~elementary-apps/scratch/scratch |
Diff against target: |
2056 lines (+647/-1169) 17 files modified
plugins/CMakeLists.txt (+1/-2) plugins/filemanager/CMakeLists.txt (+0/-29) plugins/filemanager/File.vala (+0/-207) plugins/filemanager/FileManagerPlugin.vala (+0/-113) plugins/filemanager/FileView.vala (+0/-297) plugins/filemanager/Settings.vala (+0/-36) plugins/filemanager/filemanager.plugin (+0/-10) plugins/folder-manager/CMakeLists.txt (+3/-0) plugins/folder-manager/File.vala (+112/-112) plugins/folder-manager/FileItem.vala (+39/-0) plugins/folder-manager/FileView.vala (+125/-292) plugins/folder-manager/FolderItem.vala (+245/-0) plugins/folder-manager/FolderManagerPlugin.vala (+49/-56) plugins/folder-manager/Item.vala (+69/-0) plugins/folder-manager/folder-manager.plugin (+4/-4) schemas/CMakeLists.txt (+0/-1) schemas/org.pantheon.scratch.plugins.file-manager.gschema.xml (+0/-10) |
To merge this branch: | bzr merge lp://staging/~matzipan/scratch/folder-manager-improvement |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeremy Wootten | code, function | Approve | |
Zisu Andrei (community) | Needs Resubmitting | ||
Danielle Foré | Pending | ||
Review via email: mp+312195@code.staging.launchpad.net |
This proposal supersedes a proposal from 2016-11-18.
Commit message
Merge File Manager into Folder Manager and improve usability.
Description of the change
Wrapping up the final changes for: https:/
Unmerged revisions
- 1797. By Zisu Andrei
-
Only add valid files and directories to children and update unloaded directories better
- 1796. By Zisu Andrei
-
Fix segmentation fault on unloaded folder monitor event
- 1795. By Zisu Andrei
-
Move menu items case
- 1794. By Zisu Andrei
-
Monitor files and update unloaded folders
- 1793. By Zisu Andrei
-
Check if folder is executable to avoid infinite loop
- 1792. By Zisu Andrei
-
Null the newly_created_path after it has been processed
- 1791. By Zisu Andrei
-
Fix double creation on empty folder loading
- 1790. By Zisu Andrei
-
Fix FolderItems not editable after creation
- 1789. By Zisu Andrei
-
Add new keyword to overriding function
- 1788. By Zisu Andrei
-
Add break to make it more efficient
This LGTM. My only slight concern is that folder manager is currently a default plugin. So perhaps we should have this replace that instead of the file manager plugin. That way we don't have to monkey around with the defaults and people can upgrade to the new plugin seamlessly.