Ubuntu
network-manager-applet package

Merge lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 into lp://staging/ubuntu/trusty/network-manager-applet

  1. Trusty (14.04)
  2. lp1267100
  3. Merge into trusty
Proposed by Matthieu Baerts
Status: Merged
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100
Merge into: lp://staging/ubuntu/trusty/network-manager-applet
Diff against target: 103 lines (+42/-8)
6 files modified
.pc/applied-patches (+1/-0)
.pc/git_dont_autostart_under_GNOME.patch/nm-applet.desktop.in (+13/-0)
debian/changelog (+8/-0)
debian/patches/git_dont_autostart_under_GNOME.patch (+16/-7)
debian/patches/series (+1/-0)
nm-applet.desktop.in (+3/-1)
To merge this branch: bzr merge lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Dmitry Shachnev Approve
Ubuntu Sponsors Pending
Review via email: mp+200825@code.staging.launchpad.net

Description of the change

Hello Mathieu and thank you for maintaining nm-applet packages!

With the latest version (0.9.8.4-1ubuntu1), nm-applet is no longer launched at startup on non Gnome-Shell sessions (e.g. on Cairo-Dock session).
It seems this is because this patch is no longer applied: git_dont_autostart_under_GNOME.patch

I'm proposing a new version (please see the branch linked to this bug report) which re-adds this patch.

Note that this patch should no longer be needed with the next 0.9.8.8 version: https://git.gnome.org/browse/network-manager-applet/commit/?id=e192e83c1aa136512a9d4f026f81677799af8127

To post a comment you must log in.
lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 updated
113. By Mathieu Trudel-Lapierre

* debian/rules, debian/control: Enable ModemManager1 support.
* debian/patches/nm-applet-use-indicator.patch: refresh patch for missing
  update to the get_icon function for "broadband" devices used by MM1.

Revision history for this message
Matthieu Baerts (matttbe) wrote :

Hello Mathieu,

I just updated this branch to be sync with the trunk (lp:ubuntu/network-manager-applet).

Have a nice day,

Matt

lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 updated
114. By Iain Lane

Add new patch to move on with enter in the country page of the new mobile
wizard

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Hi Matthieu,

Alberts Muktupāvels has notified me about this issue, and I noticed that you already have a MP for that — so thanks for saving my time :)

Hovewer, it is stuck for a month and Mathieu seems to not respond to it. Can you please add ~ubuntu-sponsors to reviewers list so that it shows up in the sponsoring queue?

review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

And, also, we got a new upload two days ago, so please update it before subscribing ubuntu-sponsors.

lp://staging/~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 updated
115. By Matthieu Baerts

* debian/patches/git_dont_autostart_under_GNOME.patch:
  - Re-added this patch to use AutostartCondition: launch nm-applet at
    startup on gnome-but-not-shell sessions (LP: #1267100)

Revision history for this message
Matthieu Baerts (matttbe) wrote :

Hello and thank you for your review.

I just update my branch: this new revision can be "pulled", tagged and pushed ;-)

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approving, but his really should be done against lp:~network-manager/network-manager-applet/ubuntu; I'll apply the changes there manually and upload.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches