Merge lp://staging/~matttbe/ubuntu/trusty/nautilus/lp1274740 into lp://staging/ubuntu/trusty/nautilus

Proposed by Matthieu Baerts
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp://staging/~matttbe/ubuntu/trusty/nautilus/lp1274740
Merge into: lp://staging/ubuntu/trusty/nautilus
Diff against target: 102 lines (+22/-11)
5 files modified
.pc/ubuntu_titlebar_css.patch/src/nautilus-toolbar.c (+1/-1)
debian/changelog (+7/-0)
debian/patches/ubuntu_show_titlebar.patch (+12/-8)
src/nautilus-toolbar.c (+1/-1)
src/nautilus-window.c (+1/-1)
To merge this branch: bzr merge lp://staging/~matttbe/ubuntu/trusty/nautilus/lp1274740
Reviewer Review Type Date Requested Status
Tim Lunn (community) Needs Fixing
Ubuntu branches Pending
Review via email: mp+204130@code.staging.launchpad.net

Description of the change

Hello,

This branch fixes the bug #1274740 (Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too).

With this new modification, we only have the new titlebar (CSD) on Gnome-Shell session (where DESKTOP_SESSION environment variable is set to 'gnome')

To post a comment you must log in.
Revision history for this message
Tim Lunn (darkxst) wrote :

It is not suitable to use DESKTOP_SESSION for this purpose. It really just specifies the session name, it is possible for a user to change this by installing a custom session file etc.

review: Needs Fixing
Revision history for this message
Iain Lane (laney) wrote :

I'll reject this MP because of the comments in the bug - let's revisit when the changes mentioned there land.

Revision history for this message
Iain Lane (laney) wrote :

p.s. thanks for working on this!

Unmerged revisions

345. By Matthieu Baerts

debian/patches/ubuntu_show_titlebar.patch:
Disable CSD titlebar on GNOME-but-not-shell sessions too (LP: #1274740)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches