Merge lp://staging/~matttbe/indicator-keyboard/accessible-desc into lp://staging/indicator-keyboard
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | William Hua | ||||
| Approved revision: | 110 | ||||
| Merged at revision: | 110 | ||||
| Proposed branch: | lp://staging/~matttbe/indicator-keyboard/accessible-desc | ||||
| Merge into: | lp://staging/indicator-keyboard | ||||
| Diff against target: |
33 lines (+9/-5) 1 file modified
lib/main.vala (+9/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~matttbe/indicator-keyboard/accessible-desc | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| William Hua (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added an 'accessible description'
This description is used by other applications (like Cairo-Dock) as label for this icon.
Description of the change
Hello,
Indicator-Keyboard doesn't have any 'accessible description'. (LP: #1217855)
This is maybe not so important for Unity users because I think this description is not displayed but:
* most indicators have this description (maybe just because a description can be added)
* this is easy to add it
* this description is used by other apps like Cairo-Dock
* this information can be useful
e.g. the icon can be the same for different layouts (EN UK, EN Dvorak, EN US, etc.) and Cairo-Dock can display this description in a label (just move your mouse above the icon and you will see this description, no need to display the menu just to know which layout is used).
Is it possible to merge this branch with lp:indicator-keyboard in order to add this description? :-)
| Matthieu Baerts (matttbe) wrote | # |
| PS Jenkins bot (ps-jenkins) | # |
Approve, looks good.