Merge lp://staging/~matsubara/launchpad/bug-553361-no-referrer into lp://staging/launchpad

Proposed by Diogo Matsubara
Status: Merged
Approved by: Diogo Matsubara
Approved revision: no longer in the source branch.
Merged at revision: 10829
Proposed branch: lp://staging/~matsubara/launchpad/bug-553361-no-referrer
Merge into: lp://staging/launchpad
Diff against target: 51 lines (+21/-2)
2 files modified
lib/canonical/launchpad/webapp/errorlog.py (+1/-1)
lib/canonical/launchpad/webapp/tests/test_errorlog.py (+20/-1)
To merge this branch: bzr merge lp://staging/~matsubara/launchpad/bug-553361-no-referrer
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) release-critical Approve
Brad Crittenden (community) code Approve
Gary Poster Pending
Review via email: mp+24506@code.staging.launchpad.net

Commit message

[r=bac] Fix bug 553361 by not logging an OOPS report when NoReferrerError is raised.

Description of the change

Fix bug 553361 by not logging an OOPS report when NoReferrerError is raised.

= QA =
To run the tests:
$ bin/test -u test_errorlog

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Diogo,

The branch looks good. Please alphabetize the imports at line 23 of the diff.

review: Approve (code)
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Once that's QA on edge, I'd like this cherry-picked.

review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.