Reviewers: mp+83695_code.launchpad.net, niemeyer, Message: Done. On 2011/11/29 13:11:45, niemeyer wrote: > LGTM > Just one detail: > https://codereview.appspot.com/5445048/diff/1/zk_test.go > File zk_test.go (right): > https://codereview.appspot.com/5445048/diff/1/zk_test.go#newcode1 > zk_test.go:1: package zk_test > The package name in all tests should be renamed to "zookeeper_test" as well. Description: updated the package names for the tests as well, as per Gustavo's comments. https://code.launchpad.net/~mathieu-lonjaret/gozk/zookeeper/+merge/83695 (do not edit description out of merge proposal) Please review this at https://codereview.appspot.com/5445048/ Affected files: M Makefile M retry_test.go M server.go M suite_test.go M zk.go M zk_test.go Index: Makefile ===