Merge lp://staging/~martin-v/zconfig/ipv6 into lp://staging/~fdrake/zconfig/trunk
Proposed by
Martin v. Löwis
| Status: | Merged |
|---|---|
| Merge reported by: | Martin v. Löwis |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~martin-v/zconfig/ipv6 |
| Merge into: | lp://staging/~fdrake/zconfig/trunk |
| Diff against target: |
152 lines (+51/-7) 3 files modified
ZConfig/datatypes.py (+36/-5) ZConfig/tests/test_datatypes.py (+10/-0) doc/zconfig.tex (+5/-2) |
| To merge this branch: | bzr merge lp://staging/~martin-v/zconfig/ipv6 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Fred Drake | Approve | ||
| Hanno Schlichting | Pending | ||
| Christian Theune | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch adds IPv6 support for the inet-related datatypes. It is a pre-requisite for the IPv6 support in ZEO. Test cases and documentation changes are included; I have not tried building the documentation.
For the syntactical correctness of IPv6 addresses, it relies on socket.inet_pton, which might not be available on some systems. However, it is unlikely that an IPv6 address is specified in configuration on such a system.
As before, parsing socket addresses does not perform any DNS lookups. As a consequence, it is not possible to determine whether a host name is IPv6 or IPv4 (and it may actually be both). This is represented by AF_INET; users encountering hostnames really ought to use getaddrinfo.
To post a comment you must log in.
Revision history for this message
| Martin v. Löwis (martin-v) wrote | # |
Revision history for this message
| Fred Drake (fdrake) wrote | # |
Revision history for this message
| Martin v. Löwis (martin-v) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good to merge.
Martin: Do you have the required permissions on svn.zope.org. or do you need me to land the patch?
Thanks!