Merge lp://staging/~marten-truu/plank/optional-gradients into lp://staging/plank

Interesting, some quick notes to begin with and this might go through some iterations ;-)

We want to keep it simple and "IndicatorStyle", "IndicatorColor" and "IndicatorSize" should be enough information to draw it. No need for "IndicatorSpacing" and "IndicatorHeight"!

"IndicatorStyle" should be an Enum.

Changes of Theme.vala should be in DockTheme.vala as well.

Btw, the official git repo is https://git.launchpad.net/plank/ (Mirrored to https://github.com/ricotz/plank)

Cool, I'll use git instead then. ^^

I'll try to remove possible need for spacing with bigger circles and see whether height or width could be in relation to something to remove the need for a height setting for underline type indicators.

bzr merges are still preferred though. Of course you can keep developing in git.

Oh. :D I'll just keep using bzr for this then.

In case of the circle indicator the size is a 50th of the icon size as opposed to a 10th, but it looks roughly the right size when compared to the other indicators. Not sure yet what to do about that.

I pushed some WIP to https://code.launchpad.net/~docky-core/plank/indicator-style

IndicatorStyleType.LINE requires rotation support for LEFT/RIGHT docks

I noticed the lines already look nice in the indicator-style branch :D

In my opinion the circles could use a slight boost off the ground and since this branch is pretty outdated now, I'll just paste the idea here. :D

=== modified file 'lib/Drawing/DockTheme.vala'
--- lib/Drawing/DockTheme.vala 2016-04-04 13:50:32 +0000
+++ lib/Drawing/DockTheme.vala 2016-04-04 18:58:53 +0000
@@ -226,6 +226,10 @@
   {
    // Force square if needed which eases the placement in renderer
    switch (IndicatorStyle) {
+ case IndicatorStyleType.CIRCLE:
+ height = height + height / 2;
+ width = height;
+ break;
    case IndicatorStyleType.LINE:
     if (position == Gtk.PositionType.LEFT
      || position == Gtk.PositionType.RIGHT) {
@@ -273,7 +277,7 @@
    case IndicatorStyleType.CIRCLE:
     var x = height / 2, y = x;
     cr.move_to (x, y);
- cr.arc (x, y, height / 2, 0, Math.PI * 2);
+ cr.arc (x, y, height / 3, 0, Math.PI * 2);
     cr.close_path ();
     cr.set_source_rgba (color.red, color.green, color.blue, color.alpha);
     break;

To accomplish that there is offset_factor, but I am struggling with implementation details while this hole thing is a bit hacky and needs some further thinking.

Oh. Well if I can be of service with that somehow, I'd be happy to help. :)