MOVED - Percona Playback

Merge lp://staging/~mark-pent/percona-playback/add-select-only-option into lp://staging/percona-playback

  1. add-select-only-option
  2. Merge into trunk
Proposed by Mark Pentland
Status: Needs review
Proposed branch: lp://staging/~mark-pent/percona-playback/add-select-only-option
Merge into: lp://staging/percona-playback
Diff against target: 206 lines (+114/-3)
4 files modified
Makefile.am (+5/-0)
percona_playback/query_log/query_log.cc (+17/-3)
percona_playback/query_log/query_log.h (+15/-0)
percona_playback/test/basic-select-only.cc (+77/-0)
To merge this branch: bzr merge lp://staging/~mark-pent/percona-playback/add-select-only-option
Reviewer Review Type Date Requested Status
Percona core Pending
Review via email: mp+187743@code.staging.launchpad.net

Description of the change

I have added a --query-log-select-only option to only execute SELECT statements.
Not 100% accurate (SELECT INTO) but I also use a read-only user for playback so it will catch any that slip through.
Referenced in Bug #1231391
Includes a basic test

Thanks for the good work on Percona.

Mark

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote :

This looks great! Thanks for the patch!

I'm just in the process of getting the last things done for the 0.7 release and then I'll merge this in.

One question: what is it with the "USE " query detection in this patch? Should it be a separate option?

Reply

Unmerged revisions

197. By Mark Pentland

Added --query-log-select-only option to only execute SELECT (and use) statements

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: