maas-images

Merge lp://staging/~marius-zalinauskas/maas-images/centos-hooks into lp://staging/maas-images

centos-hooks
Merge into maas-ephemerals

Proposed by Marius Žalinauskas on 2016-12-21

Status:	Rejected
Rejected by:	Scott Moser on 2018-12-14
Proposed branch:	lp://staging/~marius-zalinauskas/maas-images/centos-hooks
Merge into:	lp://staging/maas-images
Diff against target:	1739 lines (+1124/-462) 2 files modified curtin/centos6/curtin-hooks.py (+622/-224) curtin/centos7/curtin-hooks.py (+502/-238)
To merge this branch:	bzr merge lp://staging/~marius-zalinauskas/maas-images/centos-hooks
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Andres Rodriguez (community)	2016-12-21	Needs Fixing on 2017-04-06
Tom Mullaney (community)		Approve on 2017-03-14
Review via email: mp+313684@code.staging.launchpad.net

Description of the change

Heavily modified CentOS 6/7 hooks. For the most part it is curtin/commands/curthooks.py ported to CentOS with some code from old CentOS hooks.

Added functionality:

- UEFI boot. It was already kinda working on CentOS 7, but was tricky on CentOS 6.
- Simple and MD RAID layouts. No need to force the simple layout on MAAS anymore.
- IPv4 DHCP and static networking, IP aliases on physical and VLAN interfaces. Much better than original DHCP only.

lp://staging/~marius-zalinauskas/maas-images/centos-hooks updated on 2017-01-09

353. By Marius Žalinauskas <email address hidden> on 2017-01-09: Bugfix, see https://bugs.launchpad.net/maas-images/+bug/1654853

Revision history for this message

Tom Mullaney (tpmullan) wrote on 2017-03-14:

These changes work great for me. They make Maas much more usable for people that don't only work with Ubuntu.

review: Approve

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2017-04-06:

Hi Marius,

Thank you for your contribution!

In order to be able to accept your code you need to sign the Canonical Contributors Agreement. Can you please do that in [1].

That said, we have a few things that need fixing before we are able to review / land branches, to follow the procedures MAAS uses, Please:

- Separate the UEFI changes into is own branch
- Seprate the Simple/MD Raid into its own branch
- IPv4 DHCP/Static Networking, also it its own branch.

Thank you!

[1]: https://www.ubuntu.com/legal/contributors/submit

review: Needs Fixing

Revision history for this message

Scott Moser (smoser) wrote on 2018-12-14:

Marius,
Thank you for your contribution. Sorry for the confusion or delay in responding.

I'm going to mark this 'rejected' as of right now. You are welcome to re-submit it, but do so against the git repo now.

https://code.launchpad.net/maas-images

thanks!