Merge lp://staging/~mariogrip/ubuntu-system-image/device-alias into lp://staging/ubuntu-system-image/server
Proposed by
Marius Gripsgard
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~mariogrip/ubuntu-system-image/device-alias |
Merge into: | lp://staging/ubuntu-system-image/server |
Diff against target: |
84 lines (+67/-0) 1 file modified
lib/systemimage/tree.py (+67/-0) |
To merge this branch: | bzr merge lp://staging/~mariogrip/ubuntu-system-image/device-alias |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak (community) | Needs Fixing | ||
Steve Langasek (community) | Disapprove | ||
Review via email: mp+284169@code.staging.launchpad.net |
Description of the change
Add support for Device alias
To post a comment you must log in.
Unmerged revisions
- 284. By Marius Gripsgard
-
Add support for Device alias
This doesn't look like a maintainable design to me. You are attaching device aliases to individual channels. This means that the same device alias, on two different channels, can point to two different devices. And if a device is removed from a channel, there's nothing in this code that ensures the alias is removed with it; so a channel might have dangling aliases to a device that has been removed from that channel.
I would prefer to see device aliases handled globally, not per channel.