unity-webapps-qml

Merge lp://staging/~mardy/unity-webapps-qml/oa-capture into lp://staging/unity-webapps-qml

  1. oa-capture
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Needs review
Proposed branch: lp://staging/~mardy/unity-webapps-qml/oa-capture
Merge into: lp://staging/unity-webapps-qml
Diff against target: 706 lines (+552/-4)
14 files modified
.bzrignore (+32/-0)
common-project-config.pri (+12/-0)
debian/control (+2/-0)
debian/unity-webapps-qml.install (+1/-0)
src/Ubuntu/UnityWebApps/UnityWebApps.qml (+8/-1)
src/Ubuntu/UnityWebApps/plugin/com.canonical.webcredentials.capture.gschema.xml (+11/-0)
src/Ubuntu/UnityWebApps/plugin/online-accounts-capturer.cpp (+148/-0)
src/Ubuntu/UnityWebApps/plugin/online-accounts-capturer.h (+60/-0)
src/Ubuntu/UnityWebApps/plugin/plugin.pro (+15/-2)
src/Ubuntu/UnityWebApps/plugin/qml-plugin.cpp (+12/-0)
tests/unit/test_online_accounts_capturer/capture-test.provider (+8/-0)
tests/unit/test_online_accounts_capturer/test_online_accounts_capturer.cpp (+196/-0)
tests/unit/test_online_accounts_capturer/test_online_accounts_capturer.pro (+44/-0)
tests/unit/unit.pro (+3/-1)
To merge this branch: bzr merge lp://staging/~mardy/unity-webapps-qml/oa-capture
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Alexandre Abreu (community) Approve
WebApps Pending
Review via email: mp+209905@code.staging.launchpad.net

Commit message

Send username and cookies to Online Accounts

This is the reimplementation in Qt of this:
http://bazaar.launchpad.net/~online-accounts/webaccounts-browser-extension/trunk/view/head:/lib/webaccounts/login-handler.c

Description of the change

Send username and cookies to Online Accounts

This is the reimplementation in Qt of this:
http://bazaar.launchpad.net/~online-accounts/webaccounts-browser-extension/trunk/view/head:/lib/webaccounts/login-handler.c

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:89
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/85/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-amd64-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-armhf-ci/33/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/85/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
David Barth (dbarth) wrote :

Hmmm, no unit tests?

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

L97: please do not enforce the getCookies bit. It works only in the context of the webapp-container but not in other (app related) contexts where the component is uses, e.g. html5 apps. Any binding injection will fail bc of this. I'd rather see a more flexible handling & validate at runtime L110 if getcookies() is there,

L226: validate username isEmpty()?

review: Needs Fixing
Reply
lp://staging/~mardy/unity-webapps-qml/oa-capture updated
90. By Alberto Mardegan

Add unit tests

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/88/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-amd64-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-armhf-ci/36/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/88/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~mardy/unity-webapps-qml/oa-capture updated
91. By Alberto Mardegan

Don't enforce the presence of getCookies()

Revision history for this message
Alberto Mardegan (mardy) wrote :

Updated: added unit tests, remove the hard check on getCookies().

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:91
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/89/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-amd64-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-armhf-ci/37/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/89/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve
Reply
lp://staging/~mardy/unity-webapps-qml/oa-capture updated
92. By Alberto Mardegan

Merge from trunk

[ Alexandre Abreu ]
* Add some missing files striclty for doc generation for the runtime-
  api
* There is currently an issue on Ubuntu Desktop with webapps running
  in the container and bamf/unity that when a local desktop file
  exists (and a webapp icon has been pinned to the launcher through
  its global /usr/share desktop file), the webapp icons are duplicated
  in the launcher. Various fixes have been made to mitigate the issue
  in bamf but it seems to still be around. This is voluntarily
  discarded for now and left around to get to the bottom of the issue
  in a timely fashion. (LP: #1300864)
[ Alexandre Abreu ]
* Fixes to the runtime-api: have inputMethodName return its value,.
  have the client register listeners for property changed, .
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add application api (LP: #1278485)
[ Alexandre Abreu ]
* Add integration with oxide (LP: #1290535)
[ Justin McPherson ]
* Add integration with oxide (LP: #1290535)
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add support for the new content hub api
[ Alexandre Abreu ]
* Fix desktop file generation: dont do useless generation when not
  needed,. use the proper webapps-runner w/ the --chrome option. make
  sure that the webapp 'domain' is available (LP: #1288805)
* Make sure that priviledged APIs are only injected in the proper
  context (LP: #1293702)
* New rebuild forced
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Fix issue with the callback order for content hub's high level api.
  The order is reversed
[ Alexandre Abreu ]
* Fix online accounts inline docs
[ Alberto Mardegan ]
* API cleanups Add a getAccounts() method, and remove the
  getAccountsInfoFor() and getAccessTokenFor() methods.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:92
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/110/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-amd64-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-armhf-ci/58/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/110/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~mardy/unity-webapps-qml/oa-capture updated
93. By Alberto Mardegan

From trunk

[ Alexandre Abreu ]
Update the oxide bits to account for oxide moving to 1.0

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:93
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/111/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-amd64-ci/59/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-trusty-armhf-ci/59/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/111/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

93. By Alberto Mardegan

From trunk

[ Alexandre Abreu ]
Update the oxide bits to account for oxide moving to 1.0

92. By Alberto Mardegan

Merge from trunk

[ Alexandre Abreu ]
* Add some missing files striclty for doc generation for the runtime-
  api
* There is currently an issue on Ubuntu Desktop with webapps running
  in the container and bamf/unity that when a local desktop file
  exists (and a webapp icon has been pinned to the launcher through
  its global /usr/share desktop file), the webapp icons are duplicated
  in the launcher. Various fixes have been made to mitigate the issue
  in bamf but it seems to still be around. This is voluntarily
  discarded for now and left around to get to the bottom of the issue
  in a timely fashion. (LP: #1300864)
[ Alexandre Abreu ]
* Fixes to the runtime-api: have inputMethodName return its value,.
  have the client register listeners for property changed, .
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add application api (LP: #1278485)
[ Alexandre Abreu ]
* Add integration with oxide (LP: #1290535)
[ Justin McPherson ]
* Add integration with oxide (LP: #1290535)
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add support for the new content hub api
[ Alexandre Abreu ]
* Fix desktop file generation: dont do useless generation when not
  needed,. use the proper webapps-runner w/ the --chrome option. make
  sure that the webapp 'domain' is available (LP: #1288805)
* Make sure that priviledged APIs are only injected in the proper
  context (LP: #1293702)
* New rebuild forced
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Fix issue with the callback order for content hub's high level api.
  The order is reversed
[ Alexandre Abreu ]
* Fix online accounts inline docs
[ Alberto Mardegan ]
* API cleanups Add a getAccounts() method, and remove the
  getAccountsInfoFor() and getAccessTokenFor() methods.

91. By Alberto Mardegan

Don't enforce the presence of getCookies()

90. By Alberto Mardegan

Add unit tests

89. By Alberto Mardegan

Install GSettings schema

88. By Alberto Mardegan

Send website username and cookies to OA

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: