Merge lp://staging/~mardy/unity-webapps-qml/oa-api into lp://staging/unity-webapps-qml
| Status: | Merged |
|---|---|
| Approved by: | Alberto Mardegan |
| Approved revision: | 89 |
| Merged at revision: | 88 |
| Proposed branch: | lp://staging/~mardy/unity-webapps-qml/oa-api |
| Merge into: | lp://staging/unity-webapps-qml |
| Diff against target: |
362 lines (+3/-288) 3 files modified
examples/api-bindings/online-accounts/www/js/app.js (+2/-2) src/Ubuntu/UnityWebApps/UnityWebAppsBackendComponents.js (+1/-1) src/Ubuntu/UnityWebApps/bindings/online-accounts/client/online-accounts.js (+0/-285) |
| To merge this branch: | bzr merge lp://staging/~mardy/unity-webapps-qml/oa-api |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandre Abreu (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| WebApps | Pending | ||
|
Review via email:
|
|||
Commit message
Return the full dictionary of authentication parameters.
It's important to return the full reply from the authentication plugin, because there's more than the OAuth token to be returned: for instance, when authenticating with OAuth 1.0a it's possible to retrieve also the secret token that the application will have to use to encrypt its requests, or other user information such as the username.
Also, returning only the access token breaks all authentication plugins other than OAuth-based ones (plain password, SASL, for instance).
Description of the change
Return the full dictionary of authentication parameters.
It's important to return the full reply from the authentication plugin, because there's more than the OAuth token to be returned: for instance, when authenticating with OAuth 1.0a it's possible to retrieve also the secret token that the application will have to use to encrypt its requests, or other user information such as the username.
Also, returning only the access token breaks all authentication plugins other than OAuth-based ones (plain password, SASL, for instance).
| PS Jenkins bot (ps-jenkins) wrote | # |
| Alexandre Abreu (abreu-alexandre) | # |
| Alexandre Abreu (abreu-alexandre) | # |
PASSED: Continuous integration, rev:88
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://