Merge lp://staging/~mardy/ubuntuone-credentials/token-valid-1572943 into lp://staging/ubuntuone-credentials
Proposed by
Alberto Mardegan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | dobey | ||||
| Approved revision: | 239 | ||||
| Merged at revision: | 238 | ||||
| Proposed branch: | lp://staging/~mardy/ubuntuone-credentials/token-valid-1572943 | ||||
| Merge into: | lp://staging/ubuntuone-credentials | ||||
| Prerequisite: | lp://staging/~mardy/ubuntuone-credentials/library-symbols | ||||
| Diff against target: |
69 lines (+22/-10) 3 files modified
libubuntuoneauth/tests/test_token.cpp (+7/-0) libubuntuoneauth/tests/test_token.h (+1/-0) libubuntuoneauth/token.cpp (+14/-10) |
||||
| To merge this branch: | bzr merge lp://staging/~mardy/ubuntuone-credentials/token-valid-1572943 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Make Token::isValid() return false on tokens created out of empty strings.
Description of the change
Make Token::isValid() return false on tokens created out of empty strings.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:239
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://