ubuntuone-credentials

Merge lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration into lp://staging/ubuntuone-credentials/rtm-14.09

lp1376445-migration
Merge into rtm-14.09

Proposed by David Barth on 2015-02-27

Status:

Rejected

Rejected by:

dobey on 2015-03-09

Proposed branch:

lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration

Merge into:

lp://staging/ubuntuone-credentials/rtm-14.09

Diff against target:

75 lines (+34/-1)

4 files modified

acl-updater/acl-updater (+29/-0)
debian/control (+3/-0)
debian/libubuntuoneauth-2.0-0.migrations (+1/-0)
debian/rules (+1/-1)

To merge this branch:

bzr merge lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-03-09
dobey (community)		2015-02-27	Disapprove on 2015-03-09
Review via email: mp+251235@code.staging.launchpad.net

Commit message

Upgrades the ACL of U1 accounts registered in the Online Accounts database.
Add dependencies on sqlite3 and account-plugin-tools for migration script.

Description of the change

This branch upgrades the ACL of u1 accounts registered in the Online Accounts database. This avoids the bug where older accounts are removed by the u1 code to force their re-creation.

This is an old merge proposal, but I feel this would solve the problem in a more consistent way for users upgrading from old to newer releases.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-27:

PASSED: Continuous integration, rev:163
http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-ci/6/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-14.09-armhf-ci/3
deb: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-14.09-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntuone-credentials-rtm-14.09-ci/6/rebuild

review: Approve (continuous-integration)

Revision history for this message

dobey (dobey) wrote on 2015-03-03:

This will break multi-arch support in the packages, as this "script" is a compiled binary and not actually an architecture-independent script.

From dh_migrations man page:

       debian/package.migrations
           List the files and migration scripts to install into each package.
           The format is a set of lines, where each line lists a script file
           to install into into usr/share/session-migration/scripts in the
           package build directory.

The name of the files (or directories) to install should be given
relative to the current directory.

I'm also not confident that this will even work. If I understand how the ACL works, this program won't work, as it will be running unconfined, and unconfined will not yet be in the ACL. So when it tries to access the identity info, the request will be denied, meaning it won't be able to add anything to the ACL. And if this does actually work when the program is not in the ACL, and signon-apparmor-extension is installed, would it not be better to just integrate this into the normal code flow, rather than as an external migration script?

review: Disapprove

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-06:

PASSED: Continuous integration, rev:165
http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-ci/7/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-14.09-armhf-ci/4
deb: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-rtm-14.09-14.09-armhf-ci/4/artifact/work/output/*zip*/output.zip