ubuntuone-credentials

Merge lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration into lp://staging/ubuntuone-credentials

  1. lp1376445-migration
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Rejected
Rejected by: dobey
Proposed branch: lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration
Merge into: lp://staging/ubuntuone-credentials
Diff against target: 219 lines (+165/-1)
7 files modified
CMakeLists.txt (+1/-0)
acl-updater/CMakeLists.txt (+19/-0)
acl-updater/acl-updater.cpp (+94/-0)
acl-updater/acl-updater.h (+48/-0)
debian/control (+1/-0)
debian/libubuntuoneauth-2.0-0.migrations (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp://staging/~mardy/ubuntuone-credentials/lp1376445-migration
Reviewer Review Type Date Requested Status
dobey (community) Disapprove
PS Jenkins bot continuous-integration Approve
Review via email: mp+246553@code.staging.launchpad.net

Commit message

Update the ACL of the U1 account in a session migration script

Description of the change

Update the ACL of the U1 account in a session migration script

We use the session-migration facility to update the ACL of the user's U1 account. The script looks for the U1 account, and adds the "unconfined" token to the ACL if it's not already there.

I tested this on my desktop, and it seems to work fine.

It works with the signon-apparmor-extension installed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:163
http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-ci/114/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-vivid-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-vivid-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-vivid-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-vivid-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntuone-credentials-ci/114/rebuild

review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

I'm going to disapprove this. The code itself looks ok, but I think a migration script is a bit much to add here. It's more untested code, and more complexity. I don't think we should add it.

After poking at the code a little more, I've raise bug #1282392 to critical, as it is a big source of problems related to the signon-apparmor-extension addition. I will fix it today, and ping to get an approval for it in the next RTM milestone as well. With it fixed, I think we can then just treat the account as invalid, and send the user through the log-in process again, which, combined with the fix to add "unconfined" to the ACL, should be sufficient for migration.

review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches