Merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks into lp://staging/ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan
Status: Merged
Merged at revision: 297
Proposed branch: lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks
Merge into: lp://staging/ubuntu-system-settings-online-accounts
Diff against target: 2165 lines (+1979/-4)
16 files modified
.bzrignore (+3/-0)
click-hooks/accounts.cpp (+722/-0)
click-hooks/accounts.hook.in (+3/-0)
click-hooks/acl-updater.cpp (+121/-0)
click-hooks/acl-updater.h (+40/-0)
click-hooks/click-hooks.pro (+4/-0)
click-hooks/main.cpp (+24/-4)
click-hooks/online-accounts-hooks2.pro (+38/-0)
debian/control (+3/-0)
debian/ubuntu-system-settings-online-accounts.install (+1/-0)
tests/click-hooks/click-hooks.pro (+4/-0)
tests/click-hooks/fake_signond.h (+52/-0)
tests/click-hooks/signond.py (+101/-0)
tests/click-hooks/tst_online_accounts_hooks.cpp (+18/-0)
tests/click-hooks/tst_online_accounts_hooks2.cpp (+813/-0)
tests/click-hooks/tst_online_accounts_hooks2.pro (+32/-0)
To merge this branch: bzr merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
David Barth (community) Approve
Review via email: mp+267525@code.staging.launchpad.net

Commit message

Add a simplified accounts hook

Add a new account hook ("accounts") which just takes a single json file as input. The hook program generates .application and .service files as needed.

Description of the change

Add a simplified accounts hook

Add a new account hook ("accounts") which just takes a single json file as input. The hook program generates .application and .service files as needed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Barth (dbarth) wrote :

I would add a comment in the generated XML, stating that files were auto-generated (same as makefiles), and discouraging the use of the old application/service files.

291. By Alberto Mardegan

Add comment

Revision history for this message
Alberto Mardegan (mardy) wrote :

I added a comment to say that the files are auto-generated.
However, explanations on how to generate them belong to a separate programming guide (a newer version of https://developer.ubuntu.com/en/start/platform/guides/online-accounts-developer-guide/ ). Once we have it ready, we can put its link into the comment.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
292. By Alberto Mardegan

Fix hooks path

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
293. By Alberto Mardegan

Disable app when uninstalling

294. By Alberto Mardegan

disable peer bus in signond

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
295. By Alberto Mardegan

Handle missing "name" service key

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
296. By Alberto Mardegan

Add support for account plugins

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Barth (dbarth) wrote :

Clean code, unit tests and documentation update: +1 !

review: Approve
297. By Alberto Mardegan

Don't delete each other's files

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
298. By Alberto Mardegan

Plugins don't have services

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
299. By Alberto Mardegan

Use a specific timestamp file

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
300. By Alberto Mardegan

Removing existing symlinks

301. By Alberto Mardegan

Don't write .application file for plugins

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
302. By Alberto Mardegan

Add packagedir, remove stale timestamps

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
303. By Alberto Mardegan

Don't set empty name and description

libaccounts-glib won't parse the .service file if the element text is just " ".

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
304. By Alberto Mardegan

Hooks: write settings

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
305. By Alberto Mardegan

Support symbolic icon names

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches