Merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks into lp://staging/ubuntu-system-settings-online-accounts
- simplify-hooks
- Merge into trunk
Status: | Merged |
---|---|
Merged at revision: | 297 |
Proposed branch: | lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks |
Merge into: | lp://staging/ubuntu-system-settings-online-accounts |
Diff against target: |
2165 lines (+1979/-4) 16 files modified
.bzrignore (+3/-0) click-hooks/accounts.cpp (+722/-0) click-hooks/accounts.hook.in (+3/-0) click-hooks/acl-updater.cpp (+121/-0) click-hooks/acl-updater.h (+40/-0) click-hooks/click-hooks.pro (+4/-0) click-hooks/main.cpp (+24/-4) click-hooks/online-accounts-hooks2.pro (+38/-0) debian/control (+3/-0) debian/ubuntu-system-settings-online-accounts.install (+1/-0) tests/click-hooks/click-hooks.pro (+4/-0) tests/click-hooks/fake_signond.h (+52/-0) tests/click-hooks/signond.py (+101/-0) tests/click-hooks/tst_online_accounts_hooks.cpp (+18/-0) tests/click-hooks/tst_online_accounts_hooks2.cpp (+813/-0) tests/click-hooks/tst_online_accounts_hooks2.pro (+32/-0) |
To merge this branch: | bzr merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/simplify-hooks |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
David Barth (community) | Approve | ||
Review via email: mp+267525@code.staging.launchpad.net |
Commit message
Add a simplified accounts hook
Add a new account hook ("accounts") which just takes a single json file as input. The hook program generates .application and .service files as needed.
Description of the change
Add a simplified accounts hook
Add a new account hook ("accounts") which just takes a single json file as input. The hook program generates .application and .service files as needed.
PS Jenkins bot (ps-jenkins) wrote : | # |
David Barth (dbarth) wrote : | # |
I would add a comment in the generated XML, stating that files were auto-generated (same as makefiles), and discouraging the use of the old application/service files.
- 291. By Alberto Mardegan
-
Add comment
Alberto Mardegan (mardy) wrote : | # |
I added a comment to say that the files are auto-generated.
However, explanations on how to generate them belong to a separate programming guide (a newer version of https:/
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:291
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 292. By Alberto Mardegan
-
Fix hooks path
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:292
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 293. By Alberto Mardegan
-
Disable app when uninstalling
- 294. By Alberto Mardegan
-
disable peer bus in signond
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:294
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 295. By Alberto Mardegan
-
Handle missing "name" service key
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:295
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 296. By Alberto Mardegan
-
Add support for account plugins
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:296
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
David Barth (dbarth) wrote : | # |
Clean code, unit tests and documentation update: +1 !
- 297. By Alberto Mardegan
-
Don't delete each other's files
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:297
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 298. By Alberto Mardegan
-
Plugins don't have services
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:298
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 299. By Alberto Mardegan
-
Use a specific timestamp file
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:299
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 300. By Alberto Mardegan
-
Removing existing symlinks
- 301. By Alberto Mardegan
-
Don't write .application file for plugins
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:300
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:301
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 302. By Alberto Mardegan
-
Add packagedir, remove stale timestamps
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:302
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 303. By Alberto Mardegan
-
Don't set empty name and description
libaccounts-glib won't parse the .service file if the element text is just " ".
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:303
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 304. By Alberto Mardegan
-
Hooks: write settings
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:304
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 305. By Alberto Mardegan
-
Support symbolic icon names
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:305
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PASSED: Continuous integration, rev:290 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- ci/230/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 509 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- wily-amd64- ci/18 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- wily-i386- ci/18 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- wily-mako/ 349 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 509 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 509/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 22425
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- online- accounts- ci/230/ rebuild
http://