Merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/signon-page-title into lp://staging/ubuntu-system-settings-online-accounts
Proposed by
Alberto Mardegan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | David Barth | ||||
| Approved revision: | 346 | ||||
| Merged at revision: | 349 | ||||
| Proposed branch: | lp://staging/~mardy/ubuntu-system-settings-online-accounts/signon-page-title | ||||
| Merge into: | lp://staging/ubuntu-system-settings-online-accounts | ||||
| Diff against target: |
180 lines (+31/-14) 8 files modified
online-accounts-ui/browser-request.cpp (+2/-0) online-accounts-ui/dialog-request.cpp (+2/-14) online-accounts-ui/qml/SignOnUiPage.qml (+2/-0) online-accounts-ui/signonui-request.cpp (+13/-0) online-accounts-ui/signonui-request.h (+1/-0) tests/online-accounts-ui/mock/signonui-request-mock.cpp (+6/-0) tests/online-accounts-ui/mock/signonui-request-mock.h (+2/-0) tests/online-accounts-ui/tst_browser_request.cpp (+3/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/signon-page-title | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Online Accounts | Pending | ||
|
Review via email:
|
|||
Commit message
Use provider name as page title
Description of the change
Use provider name as page title
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:345
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://