Merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/qml-dialog into lp://staging/~online-accounts/ubuntu-system-settings-online-accounts/master

Proposed by Alberto Mardegan
Status: Merged
Merged at revision: 203
Proposed branch: lp://staging/~mardy/ubuntu-system-settings-online-accounts/qml-dialog
Merge into: lp://staging/~online-accounts/ubuntu-system-settings-online-accounts/master
Diff against target: 588 lines (+492/-2)
7 files modified
debian/control (+1/-0)
online-accounts-ui/dialog-request.cpp (+286/-0)
online-accounts-ui/dialog-request.h (+54/-0)
online-accounts-ui/online-accounts-ui.pro (+3/-0)
online-accounts-ui/qml/SignOnUiDialog.qml (+115/-0)
online-accounts-ui/signonui-request.cpp (+32/-2)
online-accounts-ui/ui.qrc (+1/-0)
To merge this branch: bzr merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/qml-dialog
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Review via email: mp+237970@code.staging.launchpad.net

Commit message

Implement QML dialog for password queries

Authentication plugins can request SignOnUi to show a login form to the user. Support for this action is implemented by unity7's signon-ui, but was never implemented in this project.

Description of the change

Implement QML dialog for password queries

Authentication plugins can request SignOnUi to show a login form to the user. Support for this action is implemented by unity7's signon-ui, but was never implemented in this project.

Test case:
ubuntu-system-settings-online-accounts/password-query from https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-system-settings-online-accounts

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches