Merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/lp1373279 into lp://staging/~online-accounts/ubuntu-system-settings-online-accounts/master

Proposed by Alberto Mardegan
Status: Merged
Merged at revision: 227
Proposed branch: lp://staging/~mardy/ubuntu-system-settings-online-accounts/lp1373279
Merge into: lp://staging/~online-accounts/ubuntu-system-settings-online-accounts/master
Diff against target: 580 lines (+505/-8)
8 files modified
.bzrignore (+1/-0)
system-settings-plugin/online-accounts.settings (+2/-6)
system-settings-plugin/plugin.cpp (+116/-0)
system-settings-plugin/plugin.h (+36/-0)
system-settings-plugin/system-settings-plugin.pro (+24/-1)
tests/system-settings-plugin/system-settings-plugin.pro (+32/-0)
tests/system-settings-plugin/tst_plugin.cpp (+292/-0)
tests/tests.pro (+2/-1)
To merge this branch: bzr merge lp://staging/~mardy/ubuntu-system-settings-online-accounts/lp1373279
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
Review via email: mp+247453@code.staging.launchpad.net

Commit message

Add account data as search keywords

Description of the change

Add account data as search keywords

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

small comment inline

review: Needs Fixing
226. By Alberto Mardegan

Avoid inserting duplicate keywords

227. By Alberto Mardegan

Added tests

228. By Alberto Mardegan

Remove unnecessary friend

Revision history for this message
Alberto Mardegan (mardy) wrote :

I fixed the code as suggested by Alex, and added some unit tests.

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches