Online Accounts: Sign-on daemon

Merge lp://staging/~mardy/signon/packaging into lp://staging/signon

packaging
Merge into trunk

Proposed by Alberto Mardegan on 2013-12-10

Status:

Merged

Approved by:

Ken VanDine on 2013-12-10

Approved revision:

no longer in the source branch.

Merged at revision:

609

Proposed branch:

lp://staging/~mardy/signon/packaging

Merge into:

lp://staging/signon

Diff against target:

15 lines (+4/-2)

1 file modified

src/signond/signonsessioncore.cpp (+4/-2)

To merge this branch:

bzr merge lp://staging/~mardy/signon/packaging

Related bugs:

Bug #1156776: signon-plugin-oauth2-0.15 fails to build	Low	Fix Committed
Bug #1237782: Remove architecture-dependent patches	Undecided	Fix Released
Bug #1258578: /usr/bin/signond:4:QListData::shared_null:qDeleteAll:qDeleteAll:SignonDaemonNS::SignonSessionCore::destroy:SignonDaemonNS::SignonDisposable::destroyUnused	Undecided	Fix Released
Bug #1267805: signon tests failing when built against Qt 5.2	Critical	Fix Released
Bug #1343556: Signon error at startup	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-12-10
Ken VanDine		2013-12-10	Approve on 2013-12-10
Review via email: mp+198416@code.staging.launchpad.net

Commit message

Do not use qDeleteAll() on the QObject's children

Description of the change

Do not use qDeleteAll() on the QObject's children

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2013-12-10:

#

Looks good

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-12-10:

#

PASSED: Continuous integration, rev:609
http://jenkins.qa.ubuntu.com/job/signon-ci/47/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-trusty-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-trusty-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/signon-trusty-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/signon-ci/47/rebuild

review: Approve (continuous-integration)

lp://staging/~mardy/signon/packaging updated on 2013-12-10

609. By Alberto Mardegan on 2013-12-10

Do not use qDeleteAll() on the QObject's children. Fixes: https://bugs.launchpad.net/bugs/1156776, https://bugs.launchpad.net/bugs/1237782, https://bugs.launchpad.net/bugs/1258578.

Approved by PS Jenkins bot, Ken VanDine.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Alberto Mardegan