lp://staging/~mardy/signon-ui/qt5
Created by
Alberto Mardegan
and last modified
- Get this branch:
- bzr branch lp://staging/~mardy/signon-ui/qt5
Only
Alberto Mardegan
can upload to this branch. If you are
Alberto Mardegan
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- David King (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 205 lines (+31/-6)7 files modifiedsrc/browser-request.cpp (+1/-0)
src/cookie-jar-manager.cpp (+3/-0)
src/dialog-request.cpp (+2/-0)
src/request.cpp (+13/-1)
src/signonui_dbus_adaptor.pri (+1/-1)
src/src.pro (+5/-2)
tests/unit/unit.pro (+6/-2)
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- David King (community): Approve
-
Diff: 1226 lines (+797/-66)18 files modified.bzrignore (+2/-0)
src/browser-request.cpp (+2/-4)
src/com.canonical.indicators.webcredentials.xml (+18/-0)
src/cookie-jar-manager.cpp (+3/-0)
src/dialog-request.cpp (+2/-0)
src/embed-manager.cpp (+135/-0)
src/embed-manager.h (+52/-0)
src/indicator-service.cpp (+108/-3)
src/reauthenticator.cpp (+158/-0)
src/reauthenticator.h (+62/-0)
src/request.cpp (+47/-58)
src/request.h (+3/-0)
src/signonui_dbus_adaptor.pri (+1/-1)
src/src.pro (+7/-0)
tests/unit/fake-libsignon.cpp (+120/-0)
tests/unit/test.cpp (+67/-0)
tests/unit/test.h (+1/-0)
tests/unit/unit.pro (+9/-0)
Branch information
Recent revisions
- 65. By Alberto Mardegan
-
Do not instantiate invalid QDBusMessages
QDBus does not allow creating replies out of invalid messages: there's a
Q_ASSERT for that inside the Qt code, which luckily isn't met because Qt is
built with assertions disabled.
Still, we were running into undefined behaviour. - 64. By Alberto Mardegan
-
Do not allocate the proxy factory on the stack
QNetworkProxyFa
ctory:: setApplicationP roxyFactory( ) is documented to take
ownership of the proxy factory and destroy it (with "delete") when destructed.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/signon-ui/12.10