Merge lp://staging/~mardy/signon-ui/oa-capture into lp://staging/signon-ui

Proposed by Alberto Mardegan
Status: Superseded
Proposed branch: lp://staging/~mardy/signon-ui/oa-capture
Merge into: lp://staging/signon-ui
Diff against target: 21 lines (+1/-10)
1 file modified
src/browser-request.cpp (+1/-10)
To merge this branch: bzr merge lp://staging/~mardy/signon-ui/oa-capture
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+215148@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-04-11.

Commit message

Expect cookies in their raw form

Instead of just expecting a set of "key=value" parts, expect the full cookie blob to be passed. This makes the parsing easier (as QNetworkCookie does already all the job) and make sure that cookies have the correct domain, path and expiration date.

Description of the change

Expect cookies in their raw form

Instead of just expecting a set of "key=value" parts, expect the full cookie blob to be passed. This makes the parsing easier (as QNetworkCookie does already all the job) and make sure that cookies have the correct domain, path and expiration date.

This change does not affect any other component, since at the moment the OA capture story is not enabled.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: