Merge lp://staging/~mardy/signon-ui/lp1231691 into lp://staging/signon-ui
Proposed by
Alberto Mardegan
| Status: | Merged |
|---|---|
| Approved by: | Ken VanDine |
| Approved revision: | 114 |
| Merged at revision: | 114 |
| Proposed branch: | lp://staging/~mardy/signon-ui/lp1231691 |
| Merge into: | lp://staging/signon-ui |
| Diff against target: |
189 lines (+53/-10) 4 files modified
src/browser-process/browser-process.cpp (+32/-1) src/browser-process/webview.qml (+15/-4) src/com.canonical.indicators.webcredentials.xml (+4/-4) src/request.cpp (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~mardy/signon-ui/lp1231691 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ken VanDine | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Allow the request to be cancelled from the UI.
Clients can provide a QML component to be used in order to create the authentication page, and this gives them a way to add a cancel button there.
Description of the change
Allow the request to be cancelled from the UI.
Clients can provide a QML component to be used in order to create the authentication page, and this gives them a way to add a cancel button there.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:114
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://