Merge lp://staging/~mardy/signon-ui/lp1171853 into lp://staging/signon-ui/13.04

Proposed by Alberto Mardegan
Status: Merged
Approved by: Ken VanDine
Approved revision: 87
Merged at revision: 87
Proposed branch: lp://staging/~mardy/signon-ui/lp1171853
Merge into: lp://staging/signon-ui/13.04
Diff against target: 88 lines (+22/-1)
1 file modified
src/browser-request.cpp (+22/-1)
To merge this branch: bzr merge lp://staging/~mardy/signon-ui/lp1171853
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+160382@code.staging.launchpad.net

Commit message

Wait 3 seconds before reporting a page load failure

When logging in to Google with an Ubuntu SSO account, the browser is briefly
redirected to a page which fails to load; however, the authentication then
continues successfully.
In order not to stop the authentication process, wait three seconds before
terminating the authentication with an error, and abort the timer if another
URL is queued.

Description of the change

Wait 3 seconds before reporting a page load failure

When logging in to Google with an Ubuntu SSO account, the browser is briefly
redirected to a page which fails to load; however, the authentication then
continues successfully.
In order not to stop the authentication process, wait three seconds before
terminating the authentication with an error, and abort the timer if another
URL is queued.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

A hack, but works :)

review: Approve
88. By Alberto Mardegan

Cancel fail timer when a load is in progress

If a page is loading, don't make the request fail.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches