Online Accounts: Sign-on UI

Merge lp://staging/~mardy/signon-ui/functional-tests into lp://staging/signon-ui

  1. functional-tests
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Víctor R. Ruiz
Approved revision: 75
Merged at revision: 73
Proposed branch: lp://staging/~mardy/signon-ui/functional-tests
Merge into: lp://staging/signon-ui
Diff against target: 646 lines (+254/-314)
11 files modified
.bzrignore (+2/-1)
tests/functional/.config/signon-ui/webkit-options.d/localhost.conf (+0/-4)
tests/functional/dialog.rb (+0/-135)
tests/functional/functional.pro (+0/-3)
tests/functional/reauthenticator.py (+246/-0)
tests/functional/run-with-signon-ui.sh (+1/-1)
tests/functional/server.rb (+0/-53)
tests/functional/signon-ui.sh (+1/-1)
tests/functional/tests.sh (+1/-9)
tests/functional/webpage.rb (+0/-105)
tests/tests.pro (+3/-2)
To merge this branch: bzr merge lp://staging/~mardy/signon-ui/functional-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Víctor R. Ruiz (community) Approve
David King (community) Approve
Review via email: mp+134460@code.staging.launchpad.net

Description of the change

Tests: add functional test for the reauthenticator

Simulate signond to check signon-ui reauthentication.

Remove the testability functional tests, which have been disabled for some time
already.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:74
http://s-jenkins:8080/job/signon-ui-ci/1/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=quantal,flavor=amd64/1/console
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=quantal,flavor=i386/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Project ERROR: Package libproxy-1.0 not found

Revision history for this message
David King (amigadave) wrote :

> Project ERROR: Package libproxy-1.0 not found

The packaging branch being used is out-of-date, and does not include the dependency for the libproxy development package, so just the library is installed.

It builds and checks fine here.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/signon-ui-autolanding/1/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/signon-ui-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/1/console
    FAILURE: http://s-jenkins:8080/job/signon-ui-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Packaging branch fixed.

review: Approve
Revision history for this message
Alberto Mardegan (mardy) wrote :

Victor, should we wait for Jenkins to re-test this MR, or should I just set its state to "approved"?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:74
http://s-jenkins:8080/job/signon-ui-ci/2/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=quantal,flavor=amd64/2/console
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=quantal,flavor=i386/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:74
http://s-jenkins:8080/job/signon-ui-ci/3/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=amd64/3/console
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=i386/3/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:74
http://s-jenkins:8080/job/signon-ui-ci/4/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=amd64/4/console
    SUCCESS: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=i386/4/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Please, deactivate non-unit tests by default, or anything that requires X.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

you can also try to run xfvb

Revision history for this message
Alberto Mardegan (mardy) wrote :

This merge request is just about new functional tests. :-)

They are not run if the DISPLAY variable is unset:
http://bazaar.launchpad.net/~mardy/signon-ui/functional-tests/view/head:/tests/functional/tests.sh

So, if for some reason X applications don't work in jenkins, just unset the DISPLAY variable.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I think the functional tests without high requirement on the environment (like only X), should be run in jenkins (and so, when building the package). The X server can be mocked by xfvb as mentionned quite easily ;)

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

The rules are simple: continuous integration just run unit (small) tests. Medium and big tests are run periodically (e.g. daily) but not as part of CI. So, please, deactivate them by default. I will create another job to run those.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:75
http://s-jenkins:8080/job/signon-ui-ci/5/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=amd64/5/console
    SUCCESS: http://s-jenkins:8080/job/signon-ui-ci/./build=pbuilder,distribution=raring,flavor=i386/5/console

review: Approve (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/signon-ui-autolanding/2/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/signon-ui-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/2/console
    FAILURE: http://s-jenkins:8080/job/signon-ui-autolanding/./build=pbuilder,distribution=raring,flavor=i386/2/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: