Online Accounts: Sign-on UI

Merge lp://staging/~mardy/signon-ui/export-cookies into lp://staging/signon-ui

  1. export-cookies
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 124
Merged at revision: 122
Proposed branch: lp://staging/~mardy/signon-ui/export-cookies
Merge into: lp://staging/signon-ui
Diff against target: 133 lines (+57/-0)
4 files modified
src/cookie-jar-manager.cpp (+1/-0)
src/service.cpp (+44/-0)
src/service.h (+11/-0)
src/signon-ui.pro (+1/-0)
To merge this branch: bzr merge lp://staging/~mardy/signon-ui/export-cookies
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+198233@code.staging.launchpad.net

Commit message

Add an experimental method to get the WebView cookies

This is intended to be used by the webapps container, in the attempt to reduce the number of web logins required to the user.

Description of the change

Add an experimental method to get the WebView cookies

This is intended to be used by the webapps container, in the attempt to reduce the number of web logins required to the user.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/43/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-ui-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-ui-trusty-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/signon-ui-trusty-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/signon-ui-ci/43/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks fine, my only concern is security. We need to make sure this can only be used by the webapps container. I guess we need an apparmor profile for that. Has that been discussed yet?

review: Needs Information
Revision history for this message
Alberto Mardegan (mardy) wrote :

> Looks fine, my only concern is security. We need to make sure this can only
> be used by the webapps container. I guess we need an apparmor profile for
> that. Has that been discussed yet?

Well, click packages cannot access this interface, and unconfined processes can directly read the cookies.db file anyway. :-)

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Random question:
L63: can't we have a more reliable information about the timestamp (than the last time the cookie file was touched which seems quite arbitrary)?

Revision history for this message
Alberto Mardegan (mardy) wrote :

On 12/11/2013 10:37 AM, Alexandre Abreu wrote:
> Random question:
> L63: can't we have a more reliable information about the timestamp (than the last time the cookie file was touched which seems quite arbitrary)?

I'm afraid not (or I don't have a better idea). We can try to find a
better way when Oxyde is taken into use, maybe.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

I am wondering, since the interface basically changed ... shouldn't there be (even a minor) bump in the dbus if or something?

review: Needs Information
Revision history for this message
Alberto Mardegan (mardy) wrote :

> I am wondering, since the interface basically changed ... shouldn't there be
> (even a minor) bump in the dbus if or something?

I wouldn't be so strict about this addition, it's not meant to be used by anyone other than the webapp container, and I'd like to be able to change/remove it as needed.
If you prefer, I could move it under a new interface ("com.ubuntu.SignonUi.experimental"?); I wouldn't do it if it were for me, but strictly speaking it would be the right thing to do.

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve
Revision history for this message
Ken VanDine (ken-vandine) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: