Online Accounts: Sign-on UI

Merge lp://staging/~mardy/signon-ui/end-request2 into lp://staging/signon-ui

  1. end-request2
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: David King
Approved revision: 58
Merged at revision: 58
Proposed branch: lp://staging/~mardy/signon-ui/end-request2
Merge into: lp://staging/signon-ui
Diff against target: 15 lines (+6/-0)
1 file modified
src/browser-request.cpp (+6/-0)
To merge this branch: bzr merge lp://staging/~mardy/signon-ui/end-request2
Reviewer Review Type Date Requested Status
David King (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+123921@code.staging.launchpad.net

Description of the change

Ignore any webview signals since the authentication is completed

This is needed because QWebView might still emit loadFinished(false)
(which we would interpret as an error) on the final URL, which we don't
care about anymore.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:58
http://s-jenkins:8080/job/online-accounts-signon-ui-ci/10/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/online-accounts-signon-ui-ci/./label=quantal/10/console

review: Approve (continuous-integration)
Revision history for this message
David King (amigadave) wrote :

Seems fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: