Online Accounts: signond keyring extension

Merge lp://staging/~mardy/signon-keyring-extension/mock-keyring into lp://staging/signon-keyring-extension

  1. mock-keyring
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: David King
Approved revision: 14
Merged at revision: 14
Proposed branch: lp://staging/~mardy/signon-keyring-extension/mock-keyring
Merge into: lp://staging/signon-keyring-extension
Diff against target: 417 lines (+345/-18)
4 files modified
tests/keyring-test.cpp (+3/-17)
tests/mocked-gnome-keyring.c (+304/-0)
tests/mocked-gnome-keyring.h (+36/-0)
tests/tests.pro (+2/-1)
To merge this branch: bzr merge lp://staging/~mardy/signon-keyring-extension/mock-keyring
Reviewer Review Type Date Requested Status
David King (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+119524@code.staging.launchpad.net

Description of the change

Don't use the real GNOME keyring when running tests

Mock the keyring APIs which we are using and act on a fake in-memory keyring.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:14
http://s-jenkins:8080/job/online-accounts-keyring-extension-ci/2/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/online-accounts-keyring-extension-ci/./label=precise-clean-i386/2/console

review: Approve (continuous-integration)
Revision history for this message
David King (amigadave) wrote :

Built and tested fine, looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches