Merge lp://staging/~mardy/signon-keyring-extension/libsecret into lp://staging/signon-keyring-extension

Proposed by Alberto Mardegan
Status: Merged
Approved by: Ken VanDine
Approved revision: 30
Merged at revision: 30
Proposed branch: lp://staging/~mardy/signon-keyring-extension/libsecret
Merge into: lp://staging/signon-keyring-extension
Diff against target: 782 lines (+231/-322)
8 files modified
common-vars.pri (+1/-1)
debian/changelog (+7/-0)
debian/control (+1/-1)
src/secrets-storage.cpp (+70/-132)
src/secrets-storage.h (+0/-1)
src/src.pro (+3/-1)
tests/mocked-gnome-keyring.c (+148/-185)
tests/tests.pro (+1/-1)
To merge this branch: bzr merge lp://staging/~mardy/signon-keyring-extension/libsecret
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+171224@code.staging.launchpad.net

Commit message

Migrate from libgnome-keyring to libsecret

Also tag a new upstream release.

Description of the change

Migrate from libgnome-keyring to libsecret

Also tag a new upstream release.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Excellent, looks much better than the gnome-keyring API. Tests pass and it works on the phone, ship it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches