Merge lp://staging/~mardy/online-accounts-api/test-leaks-1617180 into lp://staging/online-accounts-api
Proposed by
Alberto Mardegan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michi Henning | ||||
| Approved revision: | 44 | ||||
| Merged at revision: | 43 | ||||
| Proposed branch: | lp://staging/~mardy/online-accounts-api/test-leaks-1617180 | ||||
| Merge into: | lp://staging/online-accounts-api | ||||
| Diff against target: |
53 lines (+18/-0) 2 files modified
tests/lib/OnlineAccounts/functional_tests/functional_tests.cpp (+9/-0) tests/lib/qml_module/tst_qml_module.cpp (+9/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~mardy/online-accounts-api/test-leaks-1617180 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michi Henning (community) | Approve | ||
| Online Accounts | Pending | ||
|
Review via email:
|
|||
Commit message
Tests: run main loop to avoid memory leaks
Description of the change
Tests: run main loop to avoid memory leaks
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
That's a significant improvement, thank you! Together with the leak fix, that gets rid of the PendingCall related errors.
I'm still seeing other errors with valgrind in the tests. It would be good to chase these down as well.