Merge into trunk : providers-1627001 : Code : Ubuntu Online Accounts API

Merge lp://staging/~mardy/online-accounts-api/providers-1627001 into lp://staging/online-accounts-api

Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 52
Merged at revision: 38
Proposed branch: lp://staging/~mardy/online-accounts-api/providers-1627001
Merge into: lp://staging/online-accounts-api
Diff against target: 1839 lines (+826/-80)
34 files modified
To merge this branch: bzr merge lp://staging/~mardy/online-accounts-api/providers-1627001
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
Review via email: mp+310060@code.staging.launchpad.net

Commit message

Add provider information to public API

Allow clients to retrieve the list of available service providers, consisting of translated display name and icon URL.
Also, add a service() method to the Account class, to get the data associated with each account.

Description of the change

Add provider information to public API

Allow clients to retrieve the list of available service providers, consisting of translated display name and icon URL.
Also, add a service() method to the Account class, to get the data associated with each account.

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

I may be missing something here, but (not being familiar with the code), it looks like the translated service name is not present? We need the translated name of the service too (such as "Google" or "Dropbox", or their equivalents in Arabic script, or whatever).

35. By Alberto Mardegan

Bump dependency on libaccounts-qt

36. By Alberto Mardegan

Add missing files

37. By Alberto Mardegan

DOn't use qjsEngine() it doesn't exist in QT 5.4

Revision history for this message
Alberto Mardegan (mardy) wrote :

> I may be missing something here, but (not being familiar with the code), it
> looks like the translated service name is not present? We need the translated
> name of the service too (such as "Google" or "Dropbox", or their equivalents
> in Arabic script, or whatever).

It's there, line 549 of the diff. I'll soon prepare a test app to verify that everything is place, in case unit tests are not catching everything.

38. By Alberto Mardegan

more of the same

39. By Alberto Mardegan

Cast QList<QString> to QStringList

40. By Alberto Mardegan

Don't use Q_GADGET functionality in Qt < 5.5

41. By Alberto Mardegan

Fix typo

42. By Alberto Mardegan

type conv for qt 5.4

43. By Alberto Mardegan

fix

44. By Alberto Mardegan

skip test

45. By Alberto Mardegan

fix

46. By Alberto Mardegan

Fallback to provider's icon and display name

47. By Alberto Mardegan

test debugging

48. By Alberto Mardegan

fix test

49. By Alberto Mardegan

remove debugging

50. By Alberto Mardegan

Don't crash if serviceList property is retrieved when the model is not ready

With this fix, we also need a signal to inform the QML engine of when the
property becomes available

51. By Alberto Mardegan

Skip missing providers

52. By Alberto Mardegan

Expose enums to QML

Revision history for this message
Alberto Mardegan (mardy) wrote :

This is implemented and available for testing here: https://bileto.ubuntu.com/#/ticket/2016

See the "Test plan" in that silo for a quick way to test it.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

one inlined question

review: Approve
53. By Alberto Mardegan

Remove commented line

Preview Diff

Failed to fetch available diffs.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches