Merge lp://staging/~mardy/online-accounts-api/providers-1627001 into lp://staging/online-accounts-api
Proposed by
Alberto Mardegan
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Alberto Mardegan | ||||||||
Approved revision: | 52 | ||||||||
Merged at revision: | 38 | ||||||||
Proposed branch: | lp://staging/~mardy/online-accounts-api/providers-1627001 | ||||||||
Merge into: | lp://staging/online-accounts-api | ||||||||
Diff against target: | 1839 lines (+826/-80) | ||||||||
To merge this branch: | bzr merge lp://staging/~mardy/online-accounts-api/providers-1627001 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandre Abreu (community) | Approve | ||
Review via email: mp+310060@code.staging.launchpad.net |
Commit message
Add provider information to public API
Allow clients to retrieve the list of available service providers, consisting of translated display name and icon URL.
Also, add a service() method to the Account class, to get the data associated with each account.
Description of the change
Add provider information to public API
Allow clients to retrieve the list of available service providers, consisting of translated display name and icon URL.
Also, add a service() method to the Account class, to get the data associated with each account.
To post a comment you must log in.
I may be missing something here, but (not being familiar with the code), it looks like the translated service name is not present? We need the translated name of the service too (such as "Google" or "Dropbox", or their equivalents in Arabic script, or whatever).