Merge lp://staging/~mardy/gnome-control-center-signon/username-1565772 into lp://staging/gnome-control-center-signon

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: 187
Merged at revision: 184
Proposed branch: lp://staging/~mardy/gnome-control-center-signon/username-1565772
Merge into: lp://staging/gnome-control-center-signon
Diff against target: 250 lines (+65/-24)
5 files modified
debian/changelog (+8/-0)
debian/libaccount-plugin-1.0-0.symbols (+2/-0)
libaccount-plugin/AccountPlugin.vapi (+3/-0)
libaccount-plugin/oauth-plugin.c (+49/-23)
libaccount-plugin/oauth-plugin.h (+3/-1)
To merge this branch: bzr merge lp://staging/~mardy/gnome-control-center-signon/username-1565772
Reviewer Review Type Date Requested Status
Online Accounts Pending
Review via email: mp+290966@code.staging.launchpad.net

Commit message

Allow OAuth-based account plugins to override display name

Add a virtual method to allow account plugins to retrieve the user name, typically via REST API calls to the remote service. This will allow us to get rid of the ugly hack in signon-ui, where we retrieve the username by inspecting the DOM of the webpages.

Description of the change

Allow OAuth-based account plugins to override display name

Add a virtual method to allow account plugins to retrieve the user name, typically via REST API calls to the remote service. This will allow us to get rid of the ugly hack in signon-ui, where we retrieve the username by inspecting the DOM of the webpages.

To post a comment you must log in.
187. By Alberto Mardegan

formatting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches