Merge lp://staging/~mardy/click-reviewers-tools/new-account-hook into lp://staging/click-reviewers-tools

Proposed by Alberto Mardegan
Status: Merged
Merged at revision: 516
Proposed branch: lp://staging/~mardy/click-reviewers-tools/new-account-hook
Merge into: lp://staging/click-reviewers-tools
Diff against target: 538 lines (+367/-8)
4 files modified
clickreviews/cr_common.py (+2/-0)
clickreviews/cr_online_accounts.py (+159/-4)
clickreviews/cr_tests.py (+26/-4)
clickreviews/tests/test_cr_online_accounts.py (+180/-0)
To merge this branch: bzr merge lp://staging/~mardy/click-reviewers-tools/new-account-hook
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Approve
Review via email: mp+268445@code.staging.launchpad.net

Commit message

Support the new "accounts" hook

A new hook for Online Accounts is being added, and it's intended to replace both the "account-application" and "account-service" hooks. It takes a JSON file, which acts as a manifest for how the app uses OA, and the hook program will then generate the needed .application and .service files.

With this change we check that the new "accounts" hook becomes the mandatory OA hook starting from the 15.10 framework.

Description of the change

Support the new "accounts" hook

A new hook for Online Accounts is being added, and it's intended to replace both the "account-application" and "account-service" hooks. It takes a JSON file, which acts as a manifest for how the app uses OA, and the hook program will then generate the needed .application and .service files.

With this change we check that the new "accounts" hook becomes the mandatory OA hook starting from the 15.10 framework.

To post a comment you must log in.
511. By Alberto Mardegan

OA: the name and description keys should not be mandatory

512. By Alberto Mardegan

Support plugins in new OA hook

513. By Alberto Mardegan

Add "auth" key to plugins

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for the MP! I've got a few comments inline.

review: Needs Fixing
514. By Alberto Mardegan

Address review comments, turn 15.10 errors into warnings

Revision history for this message
Jamie Strandboge (jdstrand) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches