Merge lp://staging/~mardy/account-plugins/no-hardcoded-data into lp://staging/account-plugins

Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 95
Merged at revision: 92
Proposed branch: lp://staging/~mardy/account-plugins/no-hardcoded-data
Merge into: lp://staging/account-plugins
Diff against target: 483 lines (+151/-109)
20 files modified
configure.ac (+1/-1)
data/providers/facebook.provider.in (+16/-0)
data/providers/flickr.provider.in (+16/-0)
data/providers/foursquare.provider.in (+16/-0)
data/providers/google.provider.in (+20/-0)
data/providers/identica.provider.in (+17/-0)
data/providers/sina.provider.in (+16/-0)
data/providers/sohu.provider.in (+16/-0)
data/providers/twitter.provider.in (+15/-0)
data/providers/windows-live.provider.in (+17/-0)
debian/control (+1/-1)
src/facebook.vala (+0/-14)
src/flickr.vala (+0/-13)
src/foursquare.vala (+0/-5)
src/google.vala (+0/-24)
src/identica.vala (+0/-9)
src/sina.vala (+0/-12)
src/sohu.vala (+0/-12)
src/twitter.vala (+0/-7)
src/windows-live.vala (+0/-11)
To merge this branch: bzr merge lp://staging/~mardy/account-plugins/no-hardcoded-data
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
David King (community) Approve
Review via email: mp+148856@code.staging.launchpad.net

Commit message

Move most of the authentication settings to the .provider files.

Description of the change

Move most of the authentication settings to the .provider files.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:92
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/account-plugins/no-hardcoded-data/+merge/148856/+edit-commit-message

http://s-jenkins:8080/job/account-plugins-ci/21/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=amd64/21/console
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=raring,flavor=i386/21/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/account-plugins-ci/21//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
David King (amigadave) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches