Merge lp://staging/~mardy/account-plugins/more-https into lp://staging/account-plugins

Proposed by Alberto Mardegan
Status: Merged
Approved by: David King
Approved revision: 65
Merged at revision: 64
Proposed branch: lp://staging/~mardy/account-plugins/more-https
Merge into: lp://staging/account-plugins
Diff against target: 83 lines (+21/-3)
6 files modified
data/webkit-options/secure.flickr.com.conf (+3/-0)
src/flickr.vala (+6/-1)
src/google.vala (+1/-1)
src/sina.vala (+5/-0)
src/sohu.vala (+5/-0)
src/twitter.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~mardy/account-plugins/more-https
Reviewer Review Type Date Requested Status
David King (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+122227@code.staging.launchpad.net

Description of the change

Update plugins to work with the latest signon-ui

The security enhancements in signon-ui require some changes from some plugins, either to always use https (also in the callback URL) or to allow http.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)
Revision history for this message
David King (amigadave) wrote :

5 +UserAgent = Mozilla/5.0 (iPhone; CPU iPhone OS 5_1_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9B206 Safari/7534.48.3

I guess that there is some reason why the UserAgent is being overridden; a comment would be useful.

review: Approve
66. By Alberto Mardegan

Add explanatory comment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches