Online Accounts: Account plugins

Merge lp://staging/~mardy/account-plugins/lp1180297 into lp://staging/account-plugins/13.04

  1. lp1180297
  2. Merge into 13.04
Proposed by Alberto Mardegan
Status: Merged
Approved by: Ken VanDine
Approved revision: 97
Merged at revision: 97
Proposed branch: lp://staging/~mardy/account-plugins/lp1180297
Merge into: lp://staging/account-plugins/13.04
Diff against target: 11 lines (+1/-0)
1 file modified
data/providers/facebook.provider.in.in (+1/-0)
To merge this branch: bzr merge lp://staging/~mardy/account-plugins/lp1180297
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+165814@code.staging.launchpad.net

Commit message

Allow Facebook to connect via plain HTTP

Workaround for https://developers.facebook.com/bugs/449221825171392

Description of the change

Allow Facebook to connect via plain HTTP

Workaround for https://developers.facebook.com/bugs/449221825171392

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:97
http://jenkins.qa.ubuntu.com/job/account-plugins-13.04-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugins-13.04-raring-amd64-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/account-plugins-13.04-ci/1/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, not ideal, but we need to work around the problem with facebook. We did get approval from the security team on bug 1180297

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches