unity-js-scopes

Merge lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests into lp://staging/unity-js-scopes

  1. flesh-out-owm-tests
  2. Merge into trunk
Proposed by Marcus Tomlinson
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 131
Merged at revision: 136
Proposed branch: lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests
Merge into: lp://staging/unity-js-scopes
Prerequisite: lp://staging/~marcustomlinson/unity-js-scopes/add-coverage
Diff against target: 270 lines (+207/-5)
4 files modified
tests/owm_scope/scope/CMakeLists.txt (+6/-0)
tests/owm_scope/scope/owm_scope-settings.ini (+4/-0)
tests/owm_scope/scope/owm_scope.js (+31/-3)
tests/owm_scope/tests/test-scope.py (+166/-2)
To merge this branch: bzr merge lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+281277@code.staging.launchpad.net

Commit message

Fleshed out OWM test scope to include a regression test for recent settings bug as well as missing tests for departments and previews

To post a comment you must log in.
lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests updated
128. By Marcus Tomlinson

Merged add-coverage

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:127
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/66/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/66

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/66/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:128
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/69/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/68

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/68/rebuild

review: Approve (continuous-integration)
lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests updated
129. By Marcus Tomlinson

Add departments to owm_scope

130. By Marcus Tomlinson

Added department tests

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:130
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/75/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/76
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/76/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/75

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/75/rebuild

review: Approve (continuous-integration)
lp://staging/~marcustomlinson/unity-js-scopes/flesh-out-owm-tests updated
131. By Marcus Tomlinson

Merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:131
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/76/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/77
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/77
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/77/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/76

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/76/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: