Merge lp://staging/~marcustomlinson/unity-js-scopes/build-fixes into lp://staging/unity-js-scopes

Proposed by Marcus Tomlinson
Status: Merged
Merged at revision: 12
Proposed branch: lp://staging/~marcustomlinson/unity-js-scopes/build-fixes
Merge into: lp://staging/unity-js-scopes
Diff against target: 96 lines (+13/-17)
4 files modified
.bzrignore (+3/-0)
CMakeLists.txt (+5/-8)
src/bindings/CMakeLists.txt (+1/-3)
src/launcher/CMakeLists.txt (+4/-6)
To merge this branch: bzr merge lp://staging/~marcustomlinson/unity-js-scopes/build-fixes
Reviewer Review Type Date Requested Status
WebApps Pending
Review via email: mp+263015@code.staging.launchpad.net

Commit message

* Add .bzrignore.
* Depend on iojs and v8 from deps/ rather than system installed versions.
* Fixed install by making ADDON_BINARY_FILES relative to CMAKE_CURRENT_BINARY_DIR.
* Fixed "Error: No such module: contextify" iojs runtime error by using "--whole-archive" when linking iojs.
* Fixed iojs link order.

Description of the change

* Add .bzrignore.
* Depend on iojs and v8 from deps/ rather than system installed versions.
* Fixed install by making ADDON_BINARY_FILES relative to CMAKE_CURRENT_BINARY_DIR.
* Fixed "Error: No such module: contextify" iojs runtime error by using "--whole-archive" when linking iojs.
* Fixed iojs link order.

To post a comment you must log in.
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hey Alex, I had trouble getting things building and running on my machine. I had to make these changes to get it going.

First issue I had was unity-js-scopes-launcher not recognising the scope.ini argument from the ScopeRunner entry in the example. Then I got "Error: No such module: contextify" when node::Start() was hit.

These changes fixed the above issues I was having, but now I'm still having an issue getting the scope running via unity-scope-tool. I'm calling "unity-scope-tool './examples/simple/simple.ini'", but the scope seems to just hang on startup. Running "unity-js-scopes-launcher './examples/simple/simple.ini'", just gives me the node terminal (">"). I looks like the simple.js script is either not even running, or is failing and no error message is being shown.

Sorry for rambling, I hope I'm making sense here.

I'm not proposing that these changes are all sane :p Please have a look through them and let me know if I'm doing anything stupid / if you have any better solutions.

11. By Marcus Tomlinson

Whoops, link order fixed

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hmmm, seems I may have jumped the gun here. Sorry. I see that the "simple" scope is calling some functions that don't actually exist in the bindings.

Is this project still WIP? Or do you have some other uncommitted changes hanging around?

Let me know if I can help.

12. By Marcus Tomlinson

Merged trunk

13. By Marcus Tomlinson

Revert launcher changes

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Alex, could you please have a look at this. The aim here is to have unity-ja-scopes link against the iojs and v8 from deps/ rather than searching for system installed versions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: