Merge lp://staging/~marcustomlinson/unity-js-scopes/build-fixes into lp://staging/unity-js-scopes
Proposed by
Marcus Tomlinson
Status: | Merged |
---|---|
Merged at revision: | 12 |
Proposed branch: | lp://staging/~marcustomlinson/unity-js-scopes/build-fixes |
Merge into: | lp://staging/unity-js-scopes |
Diff against target: |
96 lines (+13/-17) 4 files modified
.bzrignore (+3/-0) CMakeLists.txt (+5/-8) src/bindings/CMakeLists.txt (+1/-3) src/launcher/CMakeLists.txt (+4/-6) |
To merge this branch: | bzr merge lp://staging/~marcustomlinson/unity-js-scopes/build-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
WebApps | Pending | ||
Review via email: mp+263015@code.staging.launchpad.net |
Commit message
* Add .bzrignore.
* Depend on iojs and v8 from deps/ rather than system installed versions.
* Fixed install by making ADDON_BINARY_FILES relative to CMAKE_CURRENT_
* Fixed "Error: No such module: contextify" iojs runtime error by using "--whole-archive" when linking iojs.
* Fixed iojs link order.
Description of the change
* Add .bzrignore.
* Depend on iojs and v8 from deps/ rather than system installed versions.
* Fixed install by making ADDON_BINARY_FILES relative to CMAKE_CURRENT_
* Fixed "Error: No such module: contextify" iojs runtime error by using "--whole-archive" when linking iojs.
* Fixed iojs link order.
To post a comment you must log in.
Hey Alex, I had trouble getting things building and running on my machine. I had to make these changes to get it going.
First issue I had was unity-js- scopes- launcher not recognising the scope.ini argument from the ScopeRunner entry in the example. Then I got "Error: No such module: contextify" when node::Start() was hit.
These changes fixed the above issues I was having, but now I'm still having an issue getting the scope running via unity-scope-tool. I'm calling "unity-scope-tool './examples/ simple/ simple. ini'", but the scope seems to just hang on startup. Running "unity- js-scopes- launcher './examples/ simple/ simple. ini'", just gives me the node terminal (">"). I looks like the simple.js script is either not even running, or is failing and no error message is being shown.
Sorry for rambling, I hope I'm making sense here.
I'm not proposing that these changes are all sane :p Please have a look through them and let me know if I'm doing anything stupid / if you have any better solutions.