net-cpp

Merge lp://staging/~marcustomlinson/net-cpp/fix_ppc_timeout-rtm into lp://staging/net-cpp/rtm-14.09

  1. fix_ppc_timeout-rtm
  2. Merge into rtm-14.09
Proposed by Marcus Tomlinson
Status: Merged
Merged at revision: 41
Proposed branch: lp://staging/~marcustomlinson/net-cpp/fix_ppc_timeout-rtm
Merge into: lp://staging/net-cpp/rtm-14.09
Diff against target: 16 lines (+5/-1)
1 file modified
src/core/net/http/impl/curl/request.h (+5/-1)
To merge this branch: bzr merge lp://staging/~marcustomlinson/net-cpp/fix_ppc_timeout-rtm
Reviewer Review Type Date Requested Status
Thomas Voß Pending
Review via email: mp+247409@code.staging.launchpad.net

Commit message

Explicitly cast milliseconds::count() to long

Description of the change

Explicitly cast milliseconds::count() to long.

On PPC, this method returns an 8-byte long long, of which libCurl is hardcoded to read only the first 4 bytes. Furthermore, PPC being Big Endian means that the first 4 bytes will be 0 for any number lower than 2147483648.

To post a comment you must log in.
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Top approving as this is literally the same change that has been approved here: https://code.launchpad.net/~marcustomlinson/net-cpp/fix_ppc_timeout/+merge/247100

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> Top approving as this is literally the same change that has been approved
> here: https://code.launchpad.net/~marcustomlinson/net-
> cpp/fix_ppc_timeout/+merge/247100

Oh oops, apparently I don't have permissions to do that. nm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: