Noise

Merge lp://staging/~marcus-lundgren/noise/fix-983670 into lp://staging/~elementary-apps/noise/trunk

  1. fix-983670
  2. Merge into trunk
Proposed by Marcus Lundgren
Status: Merged
Merged at revision: 851
Proposed branch: lp://staging/~marcus-lundgren/noise/fix-983670
Merge into: lp://staging/~elementary-apps/noise/trunk
Diff against target: 124 lines (+29/-5)
2 files modified
src/Dialogs/SmartPlaylistEditor.vala (+28/-4)
src/Widgets/InfoPanel.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~marcus-lundgren/noise/fix-983670
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Victor Martinez (community) Approve
Review via email: mp+114403@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~marcus-lundgren/noise/fix-983670 updated
852. By Marcus Lundgren

The stars are now symbolic.

853. By Marcus Lundgren

The stars are now symbolic in the info panel as well.

Revision history for this message
Victor Martinez (victored) wrote :

Looks good! I approve the code, but we still need Dan's approval, since you made the stars on the context pane symbolic.

review: Approve
Revision history for this message
Danielle Foré (danrabbit) wrote :

Yea, Marcus and I talked about it in IRC. We agreed that it might be better to use symbolic icons for better contrast, because of a11y.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches